Changeset b7fd2a0 in mainline for uspace/lib/usbhost/include/usb/host/hcd.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbhost/include/usb/host/hcd.h (modified) (2 diffs)

uspace/lib/usbhost/include/usb/host/hcd.h

@@ -49 +49 @@
 typedef struct hcd hcd_t;
 
-typedef int (*schedule_hook_t)(hcd_t *, usb_transfer_batch_t *);
-typedef int (*ep_add_hook_t)(hcd_t *, endpoint_t *);
+typedef errno_t (*schedule_hook_t)(hcd_t *, usb_transfer_batch_t *);
+typedef errno_t (*ep_add_hook_t)(hcd_t *, endpoint_t *);
 typedef void (*ep_remove_hook_t)(hcd_t *, endpoint_t *);
 typedef void (*interrupt_hook_t)(hcd_t *, uint32_t);
-typedef int (*status_hook_t)(hcd_t *, uint32_t *);
+typedef errno_t (*status_hook_t)(hcd_t *, uint32_t *);
 
 typedef struct {
@@ -102 +102 @@
 }
 
-extern int hcd_request_address(hcd_t *, usb_speed_t, usb_address_t *);
+extern errno_t hcd_request_address(hcd_t *, usb_speed_t, usb_address_t *);
 
-extern int hcd_release_address(hcd_t *, usb_address_t);
+extern errno_t hcd_release_address(hcd_t *, usb_address_t);
 
-extern int hcd_reserve_default_address(hcd_t *, usb_speed_t);
+extern errno_t hcd_reserve_default_address(hcd_t *, usb_speed_t);
 
-static inline int hcd_release_default_address(hcd_t *hcd)
+static inline errno_t hcd_release_default_address(hcd_t *hcd)
 {
         return hcd_release_address(hcd, USB_ADDRESS_DEFAULT);
 }
 
-extern int hcd_add_ep(hcd_t *, usb_target_t, usb_direction_t,
+extern errno_t hcd_add_ep(hcd_t *, usb_target_t, usb_direction_t,
     usb_transfer_type_t, size_t, unsigned int, size_t, usb_address_t,
     unsigned int);
 
-extern int hcd_remove_ep(hcd_t *, usb_target_t, usb_direction_t);
+extern errno_t hcd_remove_ep(hcd_t *, usb_target_t, usb_direction_t);
 
-extern int hcd_send_batch(hcd_t *, usb_target_t, usb_direction_t, void *,
+extern errno_t hcd_send_batch(hcd_t *, usb_target_t, usb_direction_t, void *,
     size_t, uint64_t, usbhc_iface_transfer_in_callback_t,
     usbhc_iface_transfer_out_callback_t, void *, const char *);
 
-extern int hcd_send_batch_sync(hcd_t *, usb_target_t, usb_direction_t,
+extern errno_t hcd_send_batch_sync(hcd_t *, usb_target_t, usb_direction_t,
     void *, size_t, uint64_t, const char *, size_t *);