Changeset b7fd2a0 in mainline for uspace/lib/usbvirt/src/transfer.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbvirt/src/transfer.c (modified) (8 diffs)

uspace/lib/usbvirt/src/transfer.c

@@ -50 +50 @@
  * @return Error code.
  */
-static int usbvirt_control_transfer(usbvirt_device_t *dev,
+static errno_t usbvirt_control_transfer(usbvirt_device_t *dev,
     const void *setup, size_t setup_size,
     void *data, size_t data_size, size_t *data_size_sent)
@@ -65 +65 @@
         }
 
-        int rc;
+        errno_t rc;
 
         /* Run user handler first. */
@@ -100 +100 @@
  * @return Error code.
  */
-int usbvirt_control_write(usbvirt_device_t *dev, const void *setup,
+errno_t usbvirt_control_write(usbvirt_device_t *dev, const void *setup,
     size_t setup_size, void *data, size_t data_size)
 {
@@ -119 +119 @@
  * @return Error code.
  */
-int usbvirt_control_read(usbvirt_device_t *dev, const void *setup, size_t setup_size,
+errno_t usbvirt_control_read(usbvirt_device_t *dev, const void *setup, size_t setup_size,
     void *data, size_t data_size, size_t *data_size_sent)
 {
@@ -135 +135 @@
  * @return Error code.
  */
-int usbvirt_data_out(usbvirt_device_t *dev, usb_transfer_type_t transf_type,
+errno_t usbvirt_data_out(usbvirt_device_t *dev, usb_transfer_type_t transf_type,
     usb_endpoint_t endpoint, const void *data, size_t data_size)
 {
@@ -145 +145 @@
         }
 
-        int rc = dev->ops->data_out[endpoint](dev, endpoint, transf_type,
+        errno_t rc = dev->ops->data_out[endpoint](dev, endpoint, transf_type,
             data, data_size);
 
@@ -161 +161 @@
  * @return Error code.
  */
-int usbvirt_data_in(usbvirt_device_t *dev, usb_transfer_type_t transf_type,
+errno_t usbvirt_data_in(usbvirt_device_t *dev, usb_transfer_type_t transf_type,
     usb_endpoint_t endpoint, void *data, size_t data_size, size_t *data_size_sent)
 {
@@ -172 +172 @@
 
         size_t data_size_sent_tmp;
-        int rc = dev->ops->data_in[endpoint](dev, endpoint, transf_type,
+        errno_t rc = dev->ops->data_in[endpoint](dev, endpoint, transf_type,
             data, data_size, &data_size_sent_tmp);