Changeset b7fd2a0 in mainline for uspace/srv/audio/hound/audio_data.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/audio/hound/audio_data.h (modified) (2 diffs)

uspace/srv/audio/hound/audio_data.h

@@ -75 +75 @@
 void audio_pipe_fini(audio_pipe_t *pipe);
 
-int audio_pipe_push(audio_pipe_t *pipe, audio_data_t *data);
+errno_t audio_pipe_push(audio_pipe_t *pipe, audio_data_t *data);
 audio_data_t *audio_pipe_pop(audio_pipe_t *pipe);
 
@@ -113 +113 @@
  * Reference counted buffer is created automatically.
  */
-static inline int audio_pipe_push_data(audio_pipe_t *pipe,
+static inline errno_t audio_pipe_push_data(audio_pipe_t *pipe,
     const void *data, size_t size, pcm_format_t f)
 {
         audio_data_t *adata = audio_data_create(data, size, f);
         if (adata) {
-                const int ret = audio_pipe_push(pipe, adata);
+                const errno_t ret = audio_pipe_push(pipe, adata);
                 audio_data_unref(adata);
                 return ret;