Changeset b7fd2a0 in mainline for uspace/srv/audio/hound/connection.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/audio/hound/connection.c (modified) (2 diffs)

uspace/srv/audio/hound/connection.c

@@ -101 +101 @@
  * @param format format of the destination audio buffer.
  */
-int connection_add_source_data(connection_t *connection, void *data,
+errno_t connection_add_source_data(connection_t *connection, void *data,
     size_t size, pcm_format_t format)
 {
@@ -129 +129 @@
  * @return Error code.
  */
-int connection_push_data(connection_t *connection,
+errno_t connection_push_data(connection_t *connection,
     audio_data_t *adata)
 {
         assert(connection);
         assert(adata);
-        const int ret = audio_pipe_push(&connection->fifo, adata);
+        const errno_t ret = audio_pipe_push(&connection->fifo, adata);
         if (ret == EOK && connection->sink->data_available)
                 connection->sink->data_available(connection->sink);