Changeset b7fd2a0 in mainline for uspace/srv/devman/driver.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/devman/driver.c (modified) (9 diffs)

uspace/srv/devman/driver.c

@@ -283 +283 @@
 bool start_driver(driver_t *drv)
 {
-        int rc;
+        errno_t rc;
 
         assert(fibril_mutex_is_locked(&drv->driver_mutex));
@@ -306 +306 @@
  *                      otherwise.
  */
-int stop_driver(driver_t *drv)
+errno_t stop_driver(driver_t *drv)
 {
         async_exch_t *exch;
-        int retval;
+        errno_t retval;
         
         log_msg(LOG_DEFAULT, LVL_DEBUG, "stop_driver(drv=\"%s\")", drv->name);
@@ -591 +591 @@
         
         /* Send the device name to the driver. */
-        int rc = async_data_write_start(exch, dev->pfun->name,
+        errno_t rc = async_data_write_start(exch, dev->pfun->name,
             str_size(dev->pfun->name) + 1);
         
@@ -618 +618 @@
 }
 
-int driver_dev_remove(dev_tree_t *tree, dev_node_t *dev)
+errno_t driver_dev_remove(dev_tree_t *tree, dev_node_t *dev)
 {
         async_exch_t *exch;
-        int retval;
+        errno_t retval;
         driver_t *drv;
         devman_handle_t handle;
@@ -641 +641 @@
 }
 
-int driver_dev_gone(dev_tree_t *tree, dev_node_t *dev)
+errno_t driver_dev_gone(dev_tree_t *tree, dev_node_t *dev)
 {
         async_exch_t *exch;
-        int retval;
+        errno_t retval;
         driver_t *drv;
         devman_handle_t handle;
@@ -664 +664 @@
 }
 
-int driver_fun_online(dev_tree_t *tree, fun_node_t *fun)
+errno_t driver_fun_online(dev_tree_t *tree, fun_node_t *fun)
 {
         async_exch_t *exch;
-        int retval;
+        errno_t retval;
         driver_t *drv;
         devman_handle_t handle;
@@ -692 +692 @@
 }
 
-int driver_fun_offline(dev_tree_t *tree, fun_node_t *fun)
+errno_t driver_fun_offline(dev_tree_t *tree, fun_node_t *fun)
 {
         async_exch_t *exch;
-        int retval;
+        errno_t retval;
         driver_t *drv;
         devman_handle_t handle;
@@ -721 +721 @@
 
 /** Get list of registered drivers. */
-int driver_get_list(driver_list_t *driver_list, devman_handle_t *hdl_buf,
+errno_t driver_get_list(driver_list_t *driver_list, devman_handle_t *hdl_buf,
     size_t buf_size, size_t *act_size)
 {
@@ -753 +753 @@
 
 /** Get list of device functions. */
-int driver_get_devices(driver_t *driver, devman_handle_t *hdl_buf,
+errno_t driver_get_devices(driver_t *driver, devman_handle_t *hdl_buf,
     size_t buf_size, size_t *act_size)
 {