Changeset b7fd2a0 in mainline for uspace/srv/fs/mfs/mfs_inode.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/fs/mfs/mfs_inode.c (modified) (12 diffs)

uspace/srv/fs/mfs/mfs_inode.c

@@ -34 +34 @@
 #include "mfs.h"
 
-static int
+static errno_t
 mfs_write_inode_raw(struct mfs_node *mnode);
 
-static int
+static errno_t
 mfs2_write_inode_raw(struct mfs_node *mnode);
 
-static int
+static errno_t
 mfs_read_inode_raw(const struct mfs_instance *instance,
     struct mfs_ino_info **ino_ptr, uint16_t inum);
 
-static int
+static errno_t
 mfs2_read_inode_raw(const struct mfs_instance *instance,
     struct mfs_ino_info **ino_ptr, uint32_t inum);
@@ -57 +57 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 mfs_get_inode(struct mfs_instance *inst, struct mfs_ino_info **ino_i,
     fs_index_t index)
 {
         struct mfs_sb_info *sbi = inst->sbi;
-        int r;
+        errno_t r;
 
         if (sbi->fs_version == MFS_VERSION_V1) {
@@ -75 +75 @@
 }
 
-static int
+static errno_t
 mfs_read_inode_raw(const struct mfs_instance *instance,
     struct mfs_ino_info **ino_ptr, uint16_t inum)
@@ -84 +84 @@
         block_t *b;
         int i;
-        int r;
+        errno_t r;
 
         sbi = instance->sbi;
@@ -135 +135 @@
 }
 
-static int
+static errno_t
 mfs2_read_inode_raw(const struct mfs_instance *instance,
     struct mfs_ino_info **ino_ptr, uint32_t inum)
@@ -144 +144 @@
         block_t *b;
         int i;
-        int r;
+        errno_t r;
 
         ino_i = malloc(sizeof(*ino_i));
@@ -203 +203 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 mfs_put_inode(struct mfs_node *mnode)
 {
-        int rc = EOK;
+        errno_t rc = EOK;
 
         if (!mnode->ino_i->dirty)
@@ -223 +223 @@
 }
 
-static int
+static errno_t
 mfs_write_inode_raw(struct mfs_node *mnode)
 {
         int i;
-        int r;
+        errno_t r;
         block_t *b;
         struct mfs_ino_info *ino_i = mnode->ino_i;
@@ -267 +267 @@
 }
 
-static int
+static errno_t
 mfs2_write_inode_raw(struct mfs_node *mnode)
 {
@@ -274 +274 @@
         block_t *b;
         int i;
-        int r;
+        errno_t r;
 
         const uint32_t inum = ino_i->index - 1;
@@ -321 +321 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 mfs_inode_shrink(struct mfs_node *mnode, size_t size_shrink)
 {
@@ -327 +327 @@
         struct mfs_ino_info *ino_i = mnode->ino_i;
         const size_t bs = sbi->block_size;
-        int r;
+        errno_t r;
 
         if (size_shrink == 0) {