Changeset b7fd2a0 in mainline for uspace/srv/net/dnsrsrv/dns_msg.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/dnsrsrv/dns_msg.h (modified) (1 diff)

uspace/srv/net/dnsrsrv/dns_msg.h

@@ -44 +44 @@
 #include "dns_type.h"
 
-extern int dns_message_encode(dns_message_t *, void **, size_t *);
-extern int dns_message_decode(void *, size_t, dns_message_t **);
+extern errno_t dns_message_encode(dns_message_t *, void **, size_t *);
+extern errno_t dns_message_decode(void *, size_t, dns_message_t **);
 extern dns_message_t *dns_message_new(void);
 extern void dns_message_destroy(dns_message_t *);
-extern int dns_name_decode(dns_pdu_t *, size_t, char **, size_t *);
+extern errno_t dns_name_decode(dns_pdu_t *, size_t, char **, size_t *);
 extern uint32_t dns_uint32_t_decode(uint8_t *, size_t);
 extern void dns_addr128_t_decode(uint8_t *, size_t, addr128_t);