Changeset b7fd2a0 in mainline for uspace/srv/net/inetsrv/inet_link.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/inetsrv/inet_link.c (modified) (9 diffs)

uspace/srv/net/inetsrv/inet_link.c

@@ -55 +55 @@
 static uint16_t ip_ident = 0;
 
-static int inet_iplink_recv(iplink_t *, iplink_recv_sdu_t *, ip_ver_t);
-static int inet_iplink_change_addr(iplink_t *, addr48_t);
+static errno_t inet_iplink_recv(iplink_t *, iplink_recv_sdu_t *, ip_ver_t);
+static errno_t inet_iplink_change_addr(iplink_t *, addr48_t);
 static inet_link_t *inet_link_get_by_id_locked(sysarg_t);
 
@@ -83 +83 @@
 }
 
-static int inet_iplink_recv(iplink_t *iplink, iplink_recv_sdu_t *sdu, ip_ver_t ver)
+static errno_t inet_iplink_recv(iplink_t *iplink, iplink_recv_sdu_t *sdu, ip_ver_t ver)
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_iplink_recv()");
 
-        int rc;
+        errno_t rc;
         inet_packet_t packet;
         inet_link_t *ilink;
@@ -121 +121 @@
 }
 
-static int inet_iplink_change_addr(iplink_t *iplink, addr48_t mac)
+static errno_t inet_iplink_change_addr(iplink_t *iplink, addr48_t mac)
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_iplink_change_addr(): "
@@ -158 +158 @@
 }
 
-int inet_link_open(service_id_t sid)
+errno_t inet_link_open(service_id_t sid)
 {
         inet_link_t *ilink;
         inet_addr_t iaddr;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_link_open()");
@@ -312 +312 @@
  *
  */
-int inet_link_send_dgram(inet_link_t *ilink, addr32_t lsrc, addr32_t ldest,
+errno_t inet_link_send_dgram(inet_link_t *ilink, addr32_t lsrc, addr32_t ldest,
     inet_dgram_t *dgram, uint8_t proto, uint8_t ttl, int df)
 {
@@ -352 +352 @@
         packet.size = dgram->size;
         
-        int rc;
+        errno_t rc;
         size_t offs = 0;
         
@@ -387 +387 @@
  *
  */
-int inet_link_send_dgram6(inet_link_t *ilink, addr48_t ldest,
+errno_t inet_link_send_dgram6(inet_link_t *ilink, addr48_t ldest,
     inet_dgram_t *dgram, uint8_t proto, uint8_t ttl, int df)
 {
@@ -425 +425 @@
         packet.size = dgram->size;
         
-        int rc;
+        errno_t rc;
         size_t offs = 0;
         
@@ -471 +471 @@
 
 /** Get IDs of all links. */
-int inet_link_get_id_list(sysarg_t **rid_list, size_t *rcount)
+errno_t inet_link_get_id_list(sysarg_t **rid_list, size_t *rcount)
 {
         sysarg_t *id_list;