Changeset b7fd2a0 in mainline for uspace/srv/net/inetsrv/inetping.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/inetsrv/inetping.c (modified) (9 diffs)

uspace/srv/net/inetsrv/inetping.c

@@ -58 +58 @@
 static uint16_t inetping_ident = 0;
 
-static int inetping_send(inetping_client_t *client, inetping_sdu_t *sdu)
+static errno_t inetping_send(inetping_client_t *client, inetping_sdu_t *sdu)
 {
         if (sdu->src.version != sdu->dest.version)
@@ -73 +73 @@
 }
 
-static int inetping_get_srcaddr(inetping_client_t *client,
+static errno_t inetping_get_srcaddr(inetping_client_t *client,
     inet_addr_t *remote, inet_addr_t *local)
 {
@@ -94 +94 @@
 }
 
-int inetping_recv(uint16_t ident, inetping_sdu_t *sdu)
+errno_t inetping_recv(uint16_t ident, inetping_sdu_t *sdu)
 {
         inetping_client_t *client = inetping_client_find(ident);
@@ -107 +107 @@
         aid_t req = async_send_1(exch, INETPING_EV_RECV, sdu->seq_no, &answer);
 
-        int rc = async_data_write_start(exch, &sdu->src, sizeof(sdu->src));
+        errno_t rc = async_data_write_start(exch, &sdu->src, sizeof(sdu->src));
         if (rc != EOK) {
                 async_exchange_end(exch);
@@ -130 +130 @@
         }
 
-        int retval;
+        errno_t retval;
         async_wait_for(req, &retval);
 
@@ -142 +142 @@
 
         inetping_sdu_t sdu;
-        int rc;
+        errno_t rc;
 
         sdu.seq_no = IPC_GET_ARG1(*icall);
@@ -222 +222 @@
         }
 
-        int rc = async_data_write_finalize(callid, &remote, size);
+        errno_t rc = async_data_write_finalize(callid, &remote, size);
         if (rc != EOK) {
                 async_answer_0(callid, rc);
@@ -254 +254 @@
 }
 
-static int inetping_client_init(inetping_client_t *client)
+static errno_t inetping_client_init(inetping_client_t *client)
 {
         async_sess_t *sess = async_callback_receive(EXCHANGE_SERIALIZE);
@@ -289 +289 @@
 
         inetping_client_t client;
-        int rc = inetping_client_init(&client);
+        errno_t rc = inetping_client_init(&client);
         if (rc != EOK)
                 return;