Changeset b7fd2a0 in mainline for uspace/srv/net/inetsrv/ntrans.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/inetsrv/ntrans.c (modified) (4 diffs)

uspace/srv/net/inetsrv/ntrans.c

@@ -73 +73 @@
  *
  */
-int ntrans_add(addr128_t ip_addr, addr48_t mac_addr)
+errno_t ntrans_add(addr128_t ip_addr, addr48_t mac_addr)
 {
         inet_ntrans_t *ntrans;
@@ -107 +107 @@
  *
  */
-int ntrans_remove(addr128_t ip_addr)
+errno_t ntrans_remove(addr128_t ip_addr)
 {
         inet_ntrans_t *ntrans;
@@ -134 +134 @@
  *
  */
-int ntrans_lookup(addr128_t ip_addr, addr48_t mac_addr)
+errno_t ntrans_lookup(addr128_t ip_addr, addr48_t mac_addr)
 {
         fibril_mutex_lock(&ntrans_list_lock);
@@ -156 +156 @@
  *
  */
-int ntrans_wait_timeout(suseconds_t timeout)
+errno_t ntrans_wait_timeout(suseconds_t timeout)
 {
         fibril_mutex_lock(&ntrans_list_lock);
-        int rc = fibril_condvar_wait_timeout(&ntrans_cv, &ntrans_list_lock,
+        errno_t rc = fibril_condvar_wait_timeout(&ntrans_cv, &ntrans_list_lock,
             timeout);
         fibril_mutex_unlock(&ntrans_list_lock);