Changeset b7fd2a0 in mainline for uspace/srv/ns/service.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/ns/service.c (modified) (3 diffs)

uspace/srv/ns/service.c

@@ -95 +95 @@
 static list_t pending_conn;
 
-int service_init(void)
+errno_t service_init(void)
 {
         if (!hash_table_create(&service_hash_table, 0, 0,
@@ -139 +139 @@
  *
  */
-int register_service(service_t service, sysarg_t phone, ipc_call_t *call)
+errno_t register_service(service_t service, sysarg_t phone, ipc_call_t *call)
 {
         if (hash_table_find(&service_hash_table, &service))
@@ -173 +173 @@
         sysarg_t arg3 = IPC_GET_ARG3(*call);
         sysarg_t flags = IPC_GET_ARG4(*call);
-        int retval;
+        errno_t retval;
         
         ht_link_t *link = hash_table_find(&service_hash_table, &service);