Changeset b7fd2a0 in mainline for uspace/srv/volsrv/volsrv.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/volsrv/volsrv.c (modified) (9 diffs)

uspace/srv/volsrv/volsrv.c

@@ -54 +54 @@
 static void vol_client_conn(ipc_callid_t, ipc_call_t *, void *);
 
-static int vol_init(void)
-{
-        int rc;
+static errno_t vol_init(void)
+{
+        errno_t rc;
         log_msg(LOG_DEFAULT, LVL_DEBUG, "vol_init()");
 
@@ -90 +90 @@
         size_t size;
         size_t act_size;
-        int rc;
+        errno_t rc;
 
         if (!async_data_read_receive(&callid, &size)) {
@@ -112 +112 @@
         }
 
-        int retval = async_data_read_finalize(callid, id_buf, size);
+        errno_t retval = async_data_read_finalize(callid, id_buf, size);
         free(id_buf);
 
@@ -121 +121 @@
 {
         service_id_t sid;
-        int rc;
+        errno_t rc;
 
         sid = IPC_GET_ARG1(*icall);
@@ -139 +139 @@
         vol_part_t *part;
         vol_part_info_t pinfo;
-        int rc;
+        errno_t rc;
 
         sid = IPC_GET_ARG1(*icall);
@@ -185 +185 @@
         service_id_t sid;
         vol_part_t *part;
-        int rc;
+        errno_t rc;
 
         sid = IPC_GET_ARG1(*icall);
@@ -209 +209 @@
         vol_fstype_t fstype;
         vol_label_supp_t vlsupp;
-        int rc;
+        errno_t rc;
 
         fstype = IPC_GET_ARG1(*icall);
@@ -249 +249 @@
         vol_fstype_t fstype;
         char *label;
-        int rc;
+        errno_t rc;
 
         sid = IPC_GET_ARG1(*icall);
@@ -327 +327 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
 
         printf("%s: Volume service\n", NAME);