Changes in uspace/srv/net/tl/tcp/tcp.c [86f6121:be942bc] in mainline

File:

• uspace/srv/net/tl/tcp/tcp.c (modified) (10 diffs)

uspace/srv/net/tl/tcp/tcp.c

@@ -205 +205 @@
 static int tcp_queue_received_packet(socket_core_t *, tcp_socket_data_t *,
     packet_t *, int, size_t);
-static void tcp_queue_received_end_of_data(socket_core_t *socket);
 
 static int tcp_received_msg(device_id_t, packet_t *, services_t, services_t);
@@ -454 +453 @@
 
 has_error_service:
-        fibril_rwlock_write_unlock(&tcp_globals.lock);
+        fibril_rwlock_read_unlock(&tcp_globals.lock);
 
         /* TODO error reporting/handling */
@@ -505 +504 @@
         size_t offset;
         uint32_t new_sequence_number;
-        bool forced_ack;
         int rc;
 
@@ -514 +512 @@
         assert(packet);
 
-        forced_ack = false;
-
         new_sequence_number = ntohl(header->sequence_number);
         old_incoming = socket_data->next_incoming;
 
-        if (header->finalize) {
-                socket_data->fin_incoming = new_sequence_number +
-                    total_length - TCP_HEADER_LENGTH(header);
-        }
+        if (header->finalize)
+                socket_data->fin_incoming = new_sequence_number;
 
         /* Trim begining if containing expected data */
@@ -766 +760 @@
                 /* Release duplicite or restricted */
                 pq_release_remote(tcp_globals.net_phone, packet_get_id(packet));
-                forced_ack = true;
-        }
-
-        /* If next in sequence is an incoming FIN */
-        if (socket_data->next_incoming == socket_data->fin_incoming) {
-                /* Advance sequence number */
-                socket_data->next_incoming += 1;
-
-                /* Handle FIN */
+        }
+
+        /* Change state according to the acknowledging incoming fin */
+        if (IS_IN_INTERVAL_OVERFLOW(old_incoming, socket_data->fin_incoming,
+            socket_data->next_incoming)) {
                 switch (socket_data->state) {
                 case TCP_SOCKET_FIN_WAIT_1:
@@ -781 +771 @@
                         socket_data->state = TCP_SOCKET_CLOSING;
                         break;
-                case TCP_SOCKET_ESTABLISHED:
-                        /* Queue end-of-data marker on the socket. */
-                        tcp_queue_received_end_of_data(socket);
-                        socket_data->state = TCP_SOCKET_CLOSE_WAIT;
-                        break;
+                /*case TCP_ESTABLISHED:*/
                 default:
                         socket_data->state = TCP_SOCKET_CLOSE_WAIT;
@@ -793 +779 @@
 
         packet = tcp_get_packets_to_send(socket, socket_data);
-        if (!packet && (socket_data->next_incoming != old_incoming || forced_ack)) {
+        if (!packet) {
                 /* Create the notification packet */
                 rc = tcp_create_notification_packet(&packet, socket,
@@ -849 +835 @@
 
         return EOK;
-}
-
-/** Queue end-of-data marker on the socket.
- *
- * Next element in the sequence space is FIN. Queue end-of-data marker
- * on the socket.
- *
- * @param socket        Socket
- */
-static void tcp_queue_received_end_of_data(socket_core_t *socket)
-{
-        assert(socket != NULL);
-
-        /* Notify the destination socket */
-        async_msg_5(socket->phone, NET_SOCKET_RECEIVED,
-            (sysarg_t) socket->socket_id,
-            0, 0, 0,
-            (sysarg_t) 0 /* 0 fragments == no more data */);
 }
 
@@ -1835 +1803 @@
                         fibril_rwlock_write_unlock(socket_data->local_lock);
 
-                        socket_data->state = TCP_SOCKET_SYN_SENT;
-
                         /* Send the packet */
                         printf("connecting %d\n", packet_get_id(packet));
@@ -2244 +2210 @@
 
                 tcp_prepare_operation_header(socket, socket_data, header, 0, 0);
-                rc = tcp_queue_packet(socket, socket_data, packet, total_length);
+                rc = tcp_queue_packet(socket, socket_data, packet, 0);
                 if (rc != EOK)
                         return rc;