Changeset bfa4ffa in mainline for uspace/drv/char/ns8250/ns8250.c

Timestamp:

2016-12-27T13:34:08Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9185e42

Parents:

0d9b4a8 (diff), 73d8600 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge from lp:~jakub/helenos/sun4u

This merge brings support for serial console on the QEMU sun4u machine
and by extension on any system that provides at least one device driver
for a serial port device in the 'serial' location service category and
points the 'console' boot argument to it.

The 'console' boot argument is used to differentiate character devices
that are used as a console from other character devices that may be used
for other purposes (e.g. SLIP or keyboard).

Support for real-world sun4u machines is temporarily broken. The legacy
ns16550 input port driver has been discontinued. Real-world Ultra 5,
which is fairly close to the QEMU machine should be easy to revive. In
order to support the sun4u QEMU machine, a new sun4u platform driver was
added. The isa driver was modified to be usable also for the EBUS bus.

On sparc64 the boot argument is passed in the boot-args boot prom
environment variable. On ia32 and amd64, the boot argument can be set in
grub.cfg as an argument to the multiboot command. The backslashes need
to be properly escaped. Other platforms don't have support for boot
arguments yet.

Because the user input/output subsystem is apparently not ready to drive
the serial console next to the ordinary console or the GUI, the serial
console mode is mutually exclusive with the normal
keyboard/ega/fb/compositor mode.

File:

• uspace/drv/char/ns8250/ns8250.c (modified) (6 diffs)

uspace/drv/char/ns8250/ns8250.c

@@ -163 +163 @@
         int irq;
         /** The base i/o address of the devices registers. */
-        uint32_t io_addr;
+        uintptr_t io_addr;
         /** The i/o port used to access the serial ports registers. */
         ioport8_t *port;
@@ -330 +330 @@
         
         /* Gain control over port's registers. */
-        if (pio_enable((void *)(uintptr_t) ns->io_addr, REG_COUNT,
+        if (pio_enable((void *) ns->io_addr, REG_COUNT,
             (void **) &ns->port)) {
-                ddf_msg(LVL_ERROR, "Cannot map the port %#" PRIx32
+                ddf_msg(LVL_ERROR, "Cannot map the port %#" PRIxn
                     " for device %s.", ns->io_addr, ddf_dev_get_name(ns->dev));
                 return false;
@@ -432 +432 @@
                         ioport = true;
                         ddf_msg(LVL_NOTE, "Device %s was assigned I/O address = "
-                            "0x%x.", ddf_dev_get_name(ns->dev), ns->io_addr);
+                            "0x%#" PRIxn ".", ddf_dev_get_name(ns->dev), ns->io_addr);
                         break;
                         
@@ -771 +771 @@
 {
         ns8250_t *ns = dev_ns8250(dev);
-
         uint8_t iir = pio_read_8(&ns->regs->iid);
         if ((iir & NS8250_IID_CAUSE_MASK) == NS8250_IID_CAUSE_RXSTATUS) {
@@ -781 +780 @@
         
         ns8250_read_from_device(ns);
+        irc_disable_interrupt(ns->irq);
 }
 
@@ -857 +857 @@
         }
         need_unreg_intr_handler = true;
-        
+
         /* Enable interrupt. */
         rc = ns8250_interrupt_enable(ns);