Changes in uspace/lib/c/generic/async.c [23882034:c1c0184] in mainline

File:

• uspace/lib/c/generic/async.c (modified) (11 diffs)

uspace/lib/c/generic/async.c

@@ -134 +134 @@
 
 typedef struct {
-        sysarg_t in_task_hash;
-        link_t link;
-        int refcnt;
-        void *data;
-} client_t;
-
-typedef struct {
         awaiter_t wdata;
         
@@ -146 +139 @@
         link_t link;
         
-        /** Incoming client task hash. */
-        sysarg_t in_task_hash;
         /** Incoming phone hash. */
         sysarg_t in_phone_hash;
         
-        /** Link to the client tracking structure. */
-        client_t *client;
-
         /** Messages that should be delivered to this fibril. */
         link_t msg_queue;
@@ -172 +160 @@
 fibril_local connection_t *FIBRIL_connection;
 
-static void *default_client_data_constructor(void)
-{
-        return NULL;
-}
-
-static void default_client_data_destructor(void *data)
-{
-}
-
-static async_client_data_ctor_t async_client_data_create =
-    default_client_data_constructor;
-static async_client_data_dtor_t async_client_data_destroy =
-    default_client_data_destructor;
-
-void async_set_client_data_constructor(async_client_data_ctor_t ctor)
-{
-        async_client_data_create = ctor;
-}
-
-void async_set_client_data_destructor(async_client_data_dtor_t dtor)
-{
-        async_client_data_destroy = dtor;
-}
-
-void *async_client_data_get(void)
-{
-        assert(FIBRIL_connection);
-
-        return FIBRIL_connection->client->data;
-}
-
 static void default_client_connection(ipc_callid_t callid, ipc_call_t *call);
 static void default_interrupt_received(ipc_callid_t callid, ipc_call_t *call);
@@ -217 +174 @@
 static async_client_conn_t interrupt_received = default_interrupt_received;
 
-static hash_table_t client_hash_table;
 static hash_table_t conn_hash_table;
 static LIST_INITIALIZE(timeout_list);
 
-#define CLIENT_HASH_TABLE_BUCKETS       32
-#define CONN_HASH_TABLE_BUCKETS         32
-
-static hash_index_t client_hash(unsigned long *key)
+#define CONN_HASH_TABLE_CHAINS  32
+
+/** Compute hash into the connection hash table based on the source phone hash.
+ *
+ * @param key Pointer to source phone hash.
+ *
+ * @return Index into the connection hash table.
+ *
+ */
+static hash_index_t conn_hash(unsigned long *key)
 {
         assert(key);
-        return (((*key) >> 4) % CLIENT_HASH_TABLE_BUCKETS); 
-}
-
-static int client_compare(unsigned long key[], hash_count_t keys, link_t *item)
-{
-        client_t *cl = hash_table_get_instance(item, client_t, link);
-        return (key[0] == cl->in_task_hash);
-}
-
-static void client_remove(link_t *item)
-{
-}
-
-/** Operations for the client hash table. */
-static hash_table_operations_t client_hash_table_ops = {
-        .hash = client_hash,
-        .compare = client_compare,
-        .remove_callback = client_remove
-};
-
-/** Compute hash into the connection hash table based on the source phone hash.
- *
- * @param key Pointer to source phone hash.
- *
- * @return Index into the connection hash table.
- *
- */
-static hash_index_t conn_hash(unsigned long *key)
-{
-        assert(key);
-        return (((*key) >> 4) % CONN_HASH_TABLE_BUCKETS);
+        return (((*key) >> 4) % CONN_HASH_TABLE_CHAINS);
 }
 
@@ -548 +480 @@
 static int connection_fibril(void *arg)
 {
-        unsigned long key;
-        client_t *cl;
-        link_t *lnk;
-        bool destroy = false;
-
         /*
-         * Setup fibril-local connection pointer.
+         * Setup fibril-local connection pointer and call client_connection().
+         *
          */
         FIBRIL_connection = (connection_t *) arg;
-
-        /*
-         * Add our reference for the current connection in the client task
-         * tracking structure. If this is the first reference, create and
-         * hash in a new tracking structure.
-         */
-        futex_down(&async_futex);
-        key = FIBRIL_connection->in_task_hash;
-        lnk = hash_table_find(&client_hash_table, &key);
-        if (lnk) {
-                cl = hash_table_get_instance(lnk, client_t, link);
-                cl->refcnt++;
-        } else {
-                cl = malloc(sizeof(client_t));
-                if (!cl) {
-                        ipc_answer_0(FIBRIL_connection->callid, ENOMEM);
-                        futex_up(&async_futex);
-                        return 0;
-                }
-                cl->in_task_hash = FIBRIL_connection->in_task_hash;
-                async_serialize_start();
-                cl->data = async_client_data_create();
-                async_serialize_end();
-                cl->refcnt = 1;
-                hash_table_insert(&client_hash_table, &key, &cl->link);
-        }
-        futex_up(&async_futex);
-
-        FIBRIL_connection->client = cl;
-
-        /*
-         * Call the connection handler function.
-         */
         FIBRIL_connection->cfibril(FIBRIL_connection->callid,
             &FIBRIL_connection->call);
         
-        /*
-         * Remove the reference for this client task connection.
-         */
+        /* Remove myself from the connection hash table */
         futex_down(&async_futex);
-        if (--cl->refcnt == 0) {
-                hash_table_remove(&client_hash_table, &key, 1);
-                destroy = true;
-        }
-        futex_up(&async_futex);
-
-        if (destroy) {
-                if (cl->data)
-                        async_client_data_destroy(cl->data);
-                free(cl);
-        }
-
-        /*
-         * Remove myself from the connection hash table.
-         */
-        futex_down(&async_futex);
-        key = FIBRIL_connection->in_phone_hash;
+        unsigned long key = FIBRIL_connection->in_phone_hash;
         hash_table_remove(&conn_hash_table, &key, 1);
         futex_up(&async_futex);
         
-        /*
-         * Answer all remaining messages with EHANGUP.
-         */
+        /* Answer all remaining messages with EHANGUP */
         while (!list_empty(&FIBRIL_connection->msg_queue)) {
                 msg_t *msg;
@@ -630 +505 @@
         }
         
-        /*
-         * If the connection was hung-up, answer the last call,
-         * i.e. IPC_M_PHONE_HUNGUP.
-         */
         if (FIBRIL_connection->close_callid)
                 ipc_answer_0(FIBRIL_connection->close_callid, EOK);
@@ -646 +517 @@
  * particular fibrils.
  *
- * @param in_task_hash  Identification of the incoming connection.
  * @param in_phone_hash Identification of the incoming connection.
  * @param callid        Hash of the opening IPC_M_CONNECT_ME_TO call.
@@ -659 +529 @@
  *
  */
-fid_t async_new_connection(sysarg_t in_task_hash, sysarg_t in_phone_hash,
-    ipc_callid_t callid, ipc_call_t *call,
-    void (*cfibril)(ipc_callid_t, ipc_call_t *))
+fid_t async_new_connection(sysarg_t in_phone_hash, ipc_callid_t callid,
+    ipc_call_t *call, void (*cfibril)(ipc_callid_t, ipc_call_t *))
 {
         connection_t *conn = malloc(sizeof(*conn));
@@ -670 +539 @@
         }
         
-        conn->in_task_hash = in_task_hash;
         conn->in_phone_hash = in_phone_hash;
         list_initialize(&conn->msg_queue);
@@ -724 +592 @@
         case IPC_M_CONNECT_ME_TO:
                 /* Open new connection with fibril etc. */
-                async_new_connection(call->in_task_hash, IPC_GET_ARG5(*call),
-                    callid, call, client_connection);
+                async_new_connection(IPC_GET_ARG5(*call), callid, call,
+                    client_connection);
                 goto out;
         }
@@ -876 +744 @@
 int __async_init(void)
 {
-        if (!hash_table_create(&client_hash_table, CLIENT_HASH_TABLE_BUCKETS, 1,
-            &client_hash_table_ops) || !hash_table_create(&conn_hash_table,
-            CONN_HASH_TABLE_BUCKETS, 1, &conn_hash_table_ops)) {
+        if (!hash_table_create(&conn_hash_table, CONN_HASH_TABLE_CHAINS, 1,
+            &conn_hash_table_ops)) {
+                printf("%s: Cannot create async hash table\n", "libc");
                 return ENOMEM;
         }