Changeset c53e813 in mainline

Timestamp:

2018-09-07T16:18:10Z (6 years ago)

Author:

Jiří Zárevúcky <jiri.zarevucky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e90cfa6

Parents:

3cfe2b8

Message:

Change atomic increment/decrement routines to type-generic macros

<stdatomic.h> is type-generic by design, so we don't need to restrict
ourselves to a particular type.

File:

• kernel/generic/include/atomic.h (modified) (1 diff)

kernel/generic/include/atomic.h

@@ -40 +40 @@
 #include <stdatomic.h>
 
+// TODO: Remove.
+// Before <stdatomic.h> was available, there was only one atomic type
+// equivalent to atomic_size_t. This means that in some places, atomic_t can
+// be replaced with a more appropriate type (e.g. atomic_bool for flags or
+// a signed type for potentially signed values).
+// So atomic_t should be replaced with the most appropriate type on a case by
+// case basis, and after there are no more uses, remove this type.
 typedef atomic_size_t atomic_t;
 
-static inline size_t atomic_predec(atomic_t *val)
-{
-        return atomic_fetch_sub(val, 1) - 1;
-}
+#define atomic_predec(val) \
+        (atomic_fetch_sub((val), 1) - 1)
 
-static inline size_t atomic_preinc(atomic_t *val)
-{
-        return atomic_fetch_add(val, 1) + 1;
-}
+#define atomic_preinc(val) \
+        (atomic_fetch_add((val), 1) + 1)
 
-static inline size_t atomic_postdec(atomic_t *val)
-{
-        return atomic_fetch_sub(val, 1);
-}
+#define atomic_postdec(val) \
+        atomic_fetch_sub((val), 1)
 
-static inline size_t atomic_postinc(atomic_t *val)
-{
-        return atomic_fetch_add(val, 1);
-}
+#define atomic_postinc(val) \
+        atomic_fetch_add((val), 1)
 
-static inline void atomic_dec(atomic_t *val)
-{
-        atomic_fetch_sub(val, 1);
-}
+#define atomic_dec(val) \
+        ((void) atomic_fetch_sub(val, 1))
 
-static inline void atomic_inc(atomic_t *val)
-{
-        atomic_fetch_add(val, 1);
-}
+#define atomic_inc(val) \
+        ((void) atomic_fetch_add(val, 1))
 
 #define local_atomic_exchange(var_addr, new_val) \