Changes in uspace/srv/hid/input/generic/input.c [99ac5cf:cc574511] in mainline

File:

• uspace/srv/hid/input/generic/input.c (modified) (13 diffs)

uspace/srv/hid/input/generic/input.c

@@ -64 +64 @@
 
 // FIXME: remove this header
-#include <abi/ipc/methods.h>
+#include <kernel/ipc/ipc_methods.h>
+
+/* In microseconds */
+#define DISCOVERY_POLL_INTERVAL  (10 * 1000 * 1000)
 
 #define NUM_LAYOUTS  3
@@ -273 +276 @@
         kdev->port_ops = port;
         kdev->ctl_ops = ctl;
-        kdev->svc_id = 0;
+        kdev->service_id = 0;
         
         /* Initialize port driver. */
@@ -301 +304 @@
         mdev->port_ops = port;
         mdev->proto_ops = proto;
-        mdev->svc_id = 0;
+        mdev->service_id = 0;
         
         /* Initialize port driver. */
@@ -325 +328 @@
  *
  */
-static int kbd_add_kbdev(service_id_t service_id, kbd_dev_t **kdevp)
+static int kbd_add_kbdev(service_id_t service_id)
 {
         kbd_dev_t *kdev = kbd_dev_new();
@@ -331 +334 @@
                 return -1;
         
-        kdev->svc_id = service_id;
+        kdev->service_id = service_id;
         kdev->port_ops = NULL;
         kdev->ctl_ops = &kbdev_ctl;
-        
-        int rc = loc_service_get_name(service_id, &kdev->svc_name);
-        if (rc != EOK) {
-                kdev->svc_name = NULL;
-                goto fail;
-        }
         
         /* Initialize controller driver. */
@@ -347 +344 @@
         
         list_append(&kdev->kbd_devs, &kbd_devs);
-        *kdevp = kdev;
         return EOK;
         
 fail:
-        if (kdev->svc_name != NULL)
-                free(kdev->svc_name);
         free(kdev);
         return -1;
@@ -362 +356 @@
  *
  */
-static int mouse_add_mousedev(service_id_t service_id, mouse_dev_t **mdevp)
+static int mouse_add_mousedev(service_id_t service_id)
 {
         mouse_dev_t *mdev = mouse_dev_new();
@@ -368 +362 @@
                 return -1;
         
-        mdev->svc_id = service_id;
+        mdev->service_id = service_id;
         mdev->port_ops = NULL;
         mdev->proto_ops = &mousedev_proto;
-        
-        int rc = loc_service_get_name(service_id, &mdev->svc_name);
-        if (rc != EOK) {
-                mdev->svc_name = NULL;
-                goto fail;
-        }
         
         /* Initialize controller driver. */
@@ -384 +372 @@
         
         list_append(&mdev->mouse_devs, &mouse_devs);
-        *mdevp = mdev;
         return EOK;
         
@@ -494 +481 @@
 }
 
-static int dev_check_new_kbdevs(void)
-{
-        category_id_t keyboard_cat;
+/** Periodically check for new input devices.
+ *
+ * Looks under /loc/class/keyboard and /loc/class/mouse.
+ *
+ * @param arg Ignored
+ *
+ */
+#include <sys/typefmt.h>
+static int dev_discovery_fibril(void *arg)
+{
+        category_id_t keyboard_cat, mouse_cat;
         service_id_t *svcs;
         size_t count, i;
         bool already_known;
+        const char *dev_name = "todo";
         int rc;
         
@@ -508 +504 @@
         }
         
-        /*
-         * Check for new keyboard devices
-         */
-        rc = loc_category_get_svcs(keyboard_cat, &svcs, &count);
-        if (rc != EOK) {
-                printf("%s: Failed getting list of keyboard devices.\n",
-                    NAME);
-                return EIO;
-        }
-
-        for (i = 0; i < count; i++) {
-                already_known = false;
-                
-                /* Determine whether we already know this device. */
-                list_foreach(kbd_devs, kdev_link) {
-                        kbd_dev_t *kdev = list_get_instance(kdev_link,
-                            kbd_dev_t, kbd_devs);
-                        if (kdev->svc_id == svcs[i]) {
-                                already_known = true;
-                                break;
-                        }
-                }
-                
-                if (!already_known) {
-                        kbd_dev_t *kdev;
-                        if (kbd_add_kbdev(svcs[i], &kdev) == EOK) {
-                                printf("%s: Connected keyboard device '%s'\n",
-                                    NAME, kdev->svc_name);
-                        }
-                }
-        }
-        
-        free(svcs);
-        
-        /* XXX Handle device removal */
-        
-        return EOK;
-}
-
-static int dev_check_new_mousedevs(void)
-{
-        category_id_t mouse_cat;
-        service_id_t *svcs;
-        size_t count, i;
-        bool already_known;
-        int rc;
-        
         rc = loc_category_get_id("mouse", &mouse_cat, IPC_FLAG_BLOCKING);
         if (rc != EOK) {
@@ -561 +510 @@
         }
         
-        /*
-         * Check for new mouse devices
-         */
-        rc = loc_category_get_svcs(mouse_cat, &svcs, &count);
-        if (rc != EOK) {
-                printf("%s: Failed getting list of mouse devices.\n",
-                    NAME);
-                return EIO;
-        }
-        
-        for (i = 0; i < count; i++) {
-                already_known = false;
-                
-                /* Determine whether we already know this device. */
-                list_foreach(mouse_devs, mdev_link) {
-                        mouse_dev_t *mdev = list_get_instance(mdev_link,
-                            mouse_dev_t, mouse_devs);
-                        if (mdev->svc_id == svcs[i]) {
-                                already_known = true;
-                                break;
+        while (true) {
+                async_usleep(DISCOVERY_POLL_INTERVAL);
+                
+                /*
+                 * Check for new keyboard devices
+                 */
+                rc = loc_category_get_svcs(keyboard_cat, &svcs, &count);
+                if (rc != EOK) {
+                        printf("%s: Failed getting list of keyboard devices.\n",
+                            NAME);
+                        continue;
+                }
+
+                for (i = 0; i < count; i++) {
+                        already_known = false;
+                        
+                        /* Determine whether we already know this device. */
+                        list_foreach(kbd_devs, kdev_link) {
+                                kbd_dev_t *kdev = list_get_instance(kdev_link,
+                                    kbd_dev_t, kbd_devs);
+                                if (kdev->service_id == svcs[i]) {
+                                        already_known = true;
+                                        break;
+                                }
+                        }
+
+                        if (!already_known) {
+                                if (kbd_add_kbdev(svcs[i]) == EOK) {
+                                        printf("%s: Connected keyboard device '%s'\n",
+                                            NAME, dev_name);
+                                }
                         }
                 }
                 
-                if (!already_known) {
-                        mouse_dev_t *mdev;
-                        if (mouse_add_mousedev(svcs[i], &mdev) == EOK) {
-                                printf("%s: Connected mouse device '%s'\n",
-                                    NAME, mdev->svc_name);
+                /* XXX Handle device removal */
+                
+                /*
+                 * Check for new mouse devices
+                 */
+                rc = loc_category_get_svcs(mouse_cat, &svcs, &count);
+                if (rc != EOK) {
+                        printf("%s: Failed getting list of mouse devices.\n",
+                            NAME);
+                        continue;
+                }
+
+                for (i = 0; i < count; i++) {
+                        already_known = false;
+                        
+                        /* Determine whether we already know this device. */
+                        list_foreach(mouse_devs, mdev_link) {
+                                mouse_dev_t *mdev = list_get_instance(mdev_link,
+                                    mouse_dev_t, mouse_devs);
+                                if (mdev->service_id == svcs[i]) {
+                                        already_known = true;
+                                        break;
+                                }
+                        }
+
+                        if (!already_known) {
+                                if (mouse_add_mousedev(svcs[i]) == EOK) {
+                                        printf("%s: Connected mouse device '%s'\n",
+                                            NAME, dev_name);
+                                }
                         }
                 }
-        }
-        
-        free(svcs);
-        
-        /* XXX Handle device removal */
+                
+                /* XXX Handle device removal */
+        }
         
         return EOK;
 }
 
-static int dev_check_new(void)
-{
-        int rc;
-        
-        rc = dev_check_new_kbdevs();
-        if (rc != EOK)
-                return rc;
-        
-        rc = dev_check_new_mousedevs();
-        if (rc != EOK)
-                return rc;
-
-        return EOK;
-}
-
-static void cat_change_cb(void)
-{
-        dev_check_new();
-}
-
-/** Start listening for new devices. */
-static int input_start_dev_discovery(void)
-{
-        int rc;
-
-        rc = loc_register_cat_change_cb(cat_change_cb);
-        if (rc != EOK) {
-                printf("%s: Failed registering callback for device discovery. "
-                    "(%d)\n", NAME, rc);
-                return rc;
-        }
-
-        return dev_check_new();
+/** Start a fibril for discovering new devices. */
+static void input_start_dev_discovery(void)
+{
+        fid_t fid = fibril_create(dev_discovery_fibril, NULL);
+        if (!fid) {
+                printf("%s: Failed to create device discovery fibril.\n",
+                    NAME);
+                return;
+        }
+        
+        fibril_add_ready(fid);
 }
 
@@ -654 +615 @@
         /* Add legacy keyboard devices. */
         kbd_add_legacy_devs();
-        
+
         /* Add legacy mouse devices. */
         mouse_add_legacy_devs();