Changeset ccca251 in mainline

Timestamp:

2011-04-07T16:24:21Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

53debe0, 8436590, fc35e98

Parents:

3f56c90

Message:

improve comments, use C++ style comments for TODOs and FIXMEs

Location:

uspace

Files:

• app/stats/stats.c (modified) (1 diff)
• lib/net/generic/net_checksum.c (modified) (1 diff)
• lib/net/il/ip_client.c (modified) (3 diffs)
• lib/net/include/ip_client.h (modified) (1 diff)
• lib/net/tl/socket_core.c (modified) (3 diffs)
• srv/hw/irc/apic/apic.c (modified) (1 diff)
• srv/net/il/ip/ip.c (modified) (9 diffs)
• srv/vfs/vfs_ops.c (modified) (1 diff)

uspace/app/stats/stats.c

@@ -265 +265 @@
                 /* Threads */
                 if ((off = arg_parse_short_long(argv[i], "-t", "--task=")) != -1) {
-                        /* TODO: Support for 64b range */
+                        // TODO: Support for 64b range
                         int tmp;
                         int ret = arg_parse_int(argc, argv, &i, &tmp, off);

uspace/lib/net/generic/net_checksum.c

@@ -106 +106 @@
                                 seed = (seed << 1) ^ ((uint32_t) CRC_DIVIDER_BE);
                         } else {
-                                /* shift otherwise */
+                                /* Shift otherwise */
                                 seed <<= 1;
                         }

uspace/lib/net/il/ip_client.c

@@ -123 +123 @@
                 return EOK;
 
-        /* TODO IPv6 */
-/*      case AF_INET6:
+        // TODO IPv6
+#if 0
+        case AF_INET6:
                 if (addrlen != sizeof(struct sockaddr_in6))
                         return EINVAL;
@@ -130 +131 @@
                 address_in6 = (struct sockaddr_in6 *) addr;
                 return EOK;
-*/
+#endif
 
         default:
@@ -258 +259 @@
                 header_in->data_length = htons(data_length);
                 return EOK;
-        /* TODO IPv6 */
+        // TODO IPv6
         } else {
                 return EINVAL;

uspace/lib/net/include/ip_client.h

@@ -54 +54 @@
     socklen_t, struct sockaddr *, socklen_t, size_t, void **, size_t *);
 
-/* TODO ipopt manipulation */
+// TODO ipopt manipulation
 
 #endif

uspace/lib/net/tl/socket_core.c

@@ -306 +306 @@
                 
         case AF_INET6:
-                /* TODO IPv6 */
+                // TODO IPv6
                 break;
         }
@@ -376 +376 @@
 
         count = 0;
-//      socket_id = socket_globals.last_id;
+#if 0
+        socket_id = socket_globals.last_id;
+#endif
         do {
                 if (count < SOCKET_ID_TRIES) {
@@ -388 +390 @@
                         if (socket_id < INT_MAX) {
                                 ++ socket_id;
-/*                      } else if(socket_globals.last_id) {
-*                               socket_globals.last_id = 0;
-*                               socket_id = 1;
-*/                      } else {
+#if 0
+                        } else if(socket_globals.last_id) {
+                                socket_globals.last_id = 0;
+                                socket_id = 1;
+#endif
+                        } else {
                                 return ELIMIT;
                         }

uspace/srv/hw/irc/apic/apic.c

@@ -56 +56 @@
 static int apic_enable_irq(sysarg_t irq)
 {
-        /* FIXME: TODO */
+        // FIXME: TODO
         return ENOTSUP;
 }

uspace/srv/net/il/ip/ip.c

@@ -365 +365 @@
                 
                 if (ip_netif->dhcp) {
-                        /* TODO dhcp */
+                        // TODO dhcp
                         net_free_settings(configuration, data);
                         return ENOTSUP;
@@ -398 +398 @@
                         }
                 } else {
-                        /* TODO ipv6 in separate module */
+                        // TODO ipv6 in separate module
                         net_free_settings(configuration, data);
                         return ENOTSUP;
@@ -517 +517 @@
             ip_netif->dhcp ? "dhcp" : "static");
         
-        /* TODO ipv6 addresses */
+        // TODO ipv6 addresses
         
         char address[INET_ADDRSTRLEN];
@@ -946 +946 @@
 
         /* Greatest multiple of 8 lower than content */
-        /* TODO even fragmentation? */
+        // TODO even fragmentation?
         length = length & ~0x7;
         
@@ -1212 +1212 @@
         }
         
-        /* Ff the local host is the destination */
+        /* If the local host is the destination */
         if ((route->address.s_addr == dest->s_addr) &&
             (dest->s_addr != IPV4_LOCALHOST_ADDRESS)) {
@@ -1279 +1279 @@
         in_addr_t destination;
 
-        /* TODO search set ipopt route? */
+        // TODO search set ipopt route?
         destination.s_addr = header->destination_address;
         return destination;
@@ -1321 +1321 @@
         if ((header->flags & IPFLAG_MORE_FRAGMENTS) ||
             IP_FRAGMENT_OFFSET(header)) {
-                /* TODO fragmented */
+                // TODO fragmented
                 return ENOTSUP;
         }
@@ -1437 +1437 @@
                 phone = ip_prepare_icmp_and_get_phone(0, packet, header);
                 if (phone >= 0) {
-                        /* ttl exceeded ICMP */
+                        /* TTL exceeded ICMP */
                         icmp_time_exceeded_msg(phone, ICMP_EXC_TTL, packet);
                 }
@@ -1777 +1777 @@
                 if ((type != ICMP_DEST_UNREACH) ||
                     (code != ICMP_HOST_UNREACH)) {
-                        /* No, something else */
+                        /* No, something else */
                         break;
                 }

uspace/srv/vfs/vfs_ops.c

@@ -611 +611 @@
 void vfs_open_node(ipc_callid_t rid, ipc_call_t *request)
 {
-        /* FIXME: check for sanity of the supplied fs, dev and index */
+        // FIXME: check for sanity of the supplied fs, dev and index
         
         /*