Changes in uspace/drv/block/usbmast/main.c [4172db4a:cde999a] in mainline

File:

• uspace/drv/block/usbmast/main.c (modified) (11 diffs)

uspace/drv/block/usbmast/main.c

@@ -156 +156 @@
             usb_device_get_mapped_ep_desc(dev, &bulk_out_ep);
         if (!epm_in || !epm_out || !epm_in->present || !epm_out->present) {
-                usb_log_error("Required EPs were not mapped.");
+                usb_log_error("Required EPs were not mapped.\n");
                 return ENOENT;
         }
@@ -163 +163 @@
         mdev = usb_device_data_alloc(dev, sizeof(usbmast_dev_t));
         if (mdev == NULL) {
-                usb_log_error("Failed allocating softstate.");
+                usb_log_error("Failed allocating softstate.\n");
                 return ENOMEM;
         }
@@ -169 +169 @@
         mdev->usb_dev = dev;
 
-        usb_log_info("Initializing mass storage `%s'.",
+        usb_log_info("Initializing mass storage `%s'.\n",
             usb_device_get_name(dev));
-        usb_log_debug("Bulk in endpoint: %d [%zuB].",
-            epm_in->pipe.desc.endpoint_no, epm_in->pipe.desc.max_transfer_size);
-        usb_log_debug("Bulk out endpoint: %d [%zuB].",
-            epm_out->pipe.desc.endpoint_no, epm_out->pipe.desc.max_transfer_size);
-
-        usb_log_debug("Get LUN count...");
+        usb_log_debug("Bulk in endpoint: %d [%zuB].\n",
+            epm_in->pipe.endpoint_no, epm_in->pipe.max_packet_size);
+        usb_log_debug("Bulk out endpoint: %d [%zuB].\n",
+            epm_out->pipe.endpoint_no, epm_out->pipe.max_packet_size);
+
+        usb_log_debug("Get LUN count...\n");
         mdev->lun_count = usb_masstor_get_lun_count(mdev);
         mdev->luns = calloc(mdev->lun_count, sizeof(ddf_fun_t*));
         if (mdev->luns == NULL) {
-                usb_log_error("Failed allocating luns table.");
-                return ENOMEM;
+                rc = ENOMEM;
+                usb_log_error("Failed allocating luns table.\n");
+                goto error;
         }
 
@@ -215 +216 @@
  * @param mdev          Mass storage device
  * @param lun           LUN
- * @return              EOK on success or negative error code.
+ * @return              EOK on success or an error code.
  */
 static int usbmast_fun_create(usbmast_dev_t *mdev, unsigned lun)
@@ -225 +226 @@
 
         if (asprintf(&fun_name, "l%u", lun) < 0) {
-                usb_log_error("Out of memory.");
+                usb_log_error("Out of memory.\n");
                 rc = ENOMEM;
                 goto error;
@@ -232 +233 @@
         fun = usb_device_ddf_fun_create(mdev->usb_dev, fun_exposed, fun_name);
         if (fun == NULL) {
-                usb_log_error("Failed to create DDF function %s.", fun_name);
+                usb_log_error("Failed to create DDF function %s.\n", fun_name);
                 rc = ENOMEM;
                 goto error;
@@ -240 +241 @@
         mfun = ddf_fun_data_alloc(fun, sizeof(usbmast_fun_t));
         if (mfun == NULL) {
-                usb_log_error("Failed allocating softstate.");
+                usb_log_error("Failed allocating softstate.\n");
                 rc = ENOMEM;
                 goto error;
@@ -256 +257 @@
         ddf_fun_set_conn_handler(fun, usbmast_bd_connection);
 
-        usb_log_debug("Inquire...");
+        usb_log_debug("Inquire...\n");
         usbmast_inquiry_data_t inquiry;
         rc = usbmast_inquiry(mfun, &inquiry);
         if (rc != EOK) {
-                usb_log_warning("Failed to inquire device `%s': %s.",
+                usb_log_warning("Failed to inquire device `%s': %s.\n",
                     usb_device_get_name(mdev->usb_dev), str_error(rc));
                 rc = EIO;
@@ -280 +281 @@
         rc = usbmast_read_capacity(mfun, &nblocks, &block_size);
         if (rc != EOK) {
-                usb_log_warning("Failed to read capacity, device `%s': %s.",
+                usb_log_warning("Failed to read capacity, device `%s': %s.\n",
                     usb_device_get_name(mdev->usb_dev), str_error(rc));
                 rc = EIO;
@@ -294 +295 @@
         rc = ddf_fun_bind(fun);
         if (rc != EOK) {
-                usb_log_error("Failed to bind DDF function %s: %s.",
+                usb_log_error("Failed to bind DDF function %s: %s.\n",
                     fun_name, str_error(rc));
                 goto error;
@@ -389 +390 @@
 static const usb_driver_ops_t usbmast_driver_ops = {
         .device_add = usbmast_device_add,
-        .device_remove = usbmast_device_remove,
+        .device_rem = usbmast_device_remove,
         .device_gone = usbmast_device_gone,
 };