Changes in uspace/drv/nic/rtl8139/driver.c [d51838f:cde999a] in mainline

File:

• uspace/drv/nic/rtl8139/driver.c (modified) (13 diffs)

uspace/drv/nic/rtl8139/driver.c

@@ -28 +28 @@
 
 #include <assert.h>
+#include <async.h>
 #include <errno.h>
 #include <align.h>
-#include <thread.h>
 #include <byteorder.h>
 #include <libarch/barrier.h>
@@ -217 +217 @@
  *  @param address  The place to store the address
  *
- *  @return EOK if succeed, negative error code otherwise
+ *  @return EOK if succeed, error code otherwise
  */
 inline static void rtl8139_hw_get_addr(rtl8139_t *rtl8139,
@@ -435 +435 @@
         memory_barrier();
         while(pio_read_8(io_base + CR) & CR_RST) {
-                thread_usleep(1);
+                async_usleep(1);
                 read_barrier();
         }
@@ -816 +816 @@
 /** Handle device interrupt
  *
- * @param iid    The IPC call id
  * @param icall  The IPC call structure
  * @param dev    The rtl8139 device
  *
  */
-static void rtl8139_interrupt_handler(ipc_callid_t iid, ipc_call_t *icall,
-    ddf_dev_t *dev)
+static void rtl8139_interrupt_handler(ipc_call_t *icall, ddf_dev_t *dev)
 {
         assert(dev);
@@ -844 +842 @@
  *  @param nic_data  The driver data
  *
- *  @return IRQ capability handle if the handler was registered.
- *  @return Negative error code otherwise.
- */
-inline static int rtl8139_register_int_handler(nic_t *nic_data)
+ *  @param[out] handle  IRQ capability handle if the handler was registered.
+ *
+ *  @return An error code otherwise.
+ */
+inline static int rtl8139_register_int_handler(nic_t *nic_data, cap_handle_t *handle)
 {
         rtl8139_t *rtl8139 = nic_get_specific(nic_data);
@@ -858 +857 @@
         rtl8139_irq_code.cmds[2].addr = rtl8139->io_addr + ISR;
         rtl8139_irq_code.cmds[3].addr = rtl8139->io_addr + IMR;
-        int cap = register_interrupt_handler(nic_get_ddf_dev(nic_data),
-            rtl8139->irq, rtl8139_interrupt_handler, &rtl8139_irq_code);
+        int rc = register_interrupt_handler(nic_get_ddf_dev(nic_data),
+            rtl8139->irq, rtl8139_interrupt_handler, &rtl8139_irq_code, handle);
 
         RTL8139_IRQ_STRUCT_UNLOCK();
 
-        return cap;
+        return rc;
 }
 
@@ -1026 +1025 @@
  *  @param hw_resources  Devices hardware resources
  *
- *  @return EOK if succeed, negative error code otherwise
+ *  @return EOK if succeed, error code otherwise
  */
 static int rtl8139_fill_resource_info(ddf_dev_t *dev, const hw_res_list_parsed_t
@@ -1066 +1065 @@
  *  @param dev  The device structure
  *
- *  @return EOK if succeed, negative error code otherwise
+ *  @return EOK if succeed, error code otherwise
  */
 static int rtl8139_get_resource_info(ddf_dev_t *dev)
@@ -1148 +1147 @@
  *  @param dev  The device information
  *
- *  @return EOK if succeed, negative error code otherwise
+ *  @return EOK if succeed, error code otherwise
  */
 static int rtl8139_device_initialize(ddf_dev_t *dev)
@@ -1207 +1206 @@
  * @param dev  The RTL8139 device.
  *
- * @return EOK if successed, negative error code otherwise
+ * @return EOK if successed, error code otherwise
  */
 static int rtl8139_pio_enable(ddf_dev_t *dev)
@@ -1257 +1256 @@
  * @param dev  The RTL8139 device.
  *
- * @return EOK if added successfully, negative error code otherwise
+ * @return EOK if added successfully, error code otherwise
  */
 int rtl8139_dev_add(ddf_dev_t *dev)
@@ -1289 +1288 @@
 
         /* Register interrupt handler */
-        int irq_cap = rtl8139_register_int_handler(nic_data);
-        if (irq_cap < 0) {
-                rc = irq_cap;
+        int irq_cap;
+        rc = rtl8139_register_int_handler(nic_data, &irq_cap);
+        if (rc != EOK) {
                 goto err_pio;
         }
@@ -1340 +1339 @@
  *  @param max_len  Maximal addresss length to store
  *
- *  @return EOK if succeed, negative error code otherwise
+ *  @return EOK if succeed, error code otherwise
  */
 static int rtl8139_set_addr(ddf_fun_t *fun, const nic_address_t *addr)