Changeset cffa14e6 in mainline for uspace/drv/bus/usb/ohci/hc.c

Timestamp:

2013-07-24T17:27:56Z (11 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

db71e2a

Parents:

c442f63

Message:

revert usb hc macro changes

File:

• uspace/drv/bus/usb/ohci/hc.c (modified) (8 diffs)

uspace/drv/bus/usb/ohci/hc.c

@@ -35 +35 @@
 
 #include <errno.h>
-#include <stdbool.h>
 #include <str_error.h>
 #include <adt/list.h>
@@ -84 +83 @@
 };
 
-enum {
-        /** Number of PIO ranges used in IRQ code */
-        hc_irq_pio_range_count = 
-            sizeof(ohci_pio_ranges) / sizeof(irq_pio_range_t),
-
-        /** Number of commands used in IRQ code */
-        hc_irq_cmd_count =
-            sizeof(ohci_irq_commands) / sizeof(irq_cmd_t)
-};
-
 static void hc_gain_control(hc_t *instance);
 static void hc_start(hc_t *instance);
@@ -100 +89 @@
 static int interrupt_emulator(hc_t *instance);
 static int hc_schedule(hcd_t *hcd, usb_transfer_batch_t *batch);
+
+/** Get number of PIO ranges used in IRQ code.
+ * @return Number of ranges.
+ */
+size_t hc_irq_pio_range_count(void)
+{
+        return sizeof(ohci_pio_ranges) / sizeof(irq_pio_range_t);
+}
+
+/** Get number of commands used in IRQ code.
+ * @return Number of commands.
+ */
+size_t hc_irq_cmd_count(void)
+{
+        return sizeof(ohci_irq_commands) / sizeof(irq_cmd_t);
+}
 
 /** Generate IRQ code.
@@ -132 +137 @@
 }
 
-/** Register interrupt handler.
- *
- * @param[in] device Host controller DDF device
- * @param[in] reg_base Register range base
- * @param[in] reg_size Register range size
- * @param[in] irq Interrupt number
- * @paran[in] handler Interrupt handler
- *
- * @return EOK on success or negative error code
- */
-int hc_register_irq_handler(ddf_dev_t *device, uintptr_t reg_base, size_t reg_size,
-    int irq, interrupt_handler_t handler)
-{
-        int rc;
-
-        irq_pio_range_t irq_ranges[hc_irq_pio_range_count];
-        irq_cmd_t irq_cmds[hc_irq_cmd_count];
-
-        irq_code_t irq_code = {
-                .rangecount = hc_irq_pio_range_count,
-                .ranges = irq_ranges,
-                .cmdcount = hc_irq_cmd_count,
-                .cmds = irq_cmds
-        };
-
-        rc = hc_get_irq_code(irq_ranges, sizeof(irq_ranges), irq_cmds,
-            sizeof(irq_cmds), reg_base, reg_size);
-        if (rc != EOK) {
-                usb_log_error("Failed to generate IRQ code: %s.\n",
-                    str_error(rc));
-                return rc;
-        }
-
-        /* Register handler to avoid interrupt lockup */
-        rc = register_interrupt_handler(device, irq, handler, &irq_code);
-        if (rc != EOK) {
-                usb_log_error("Failed to register interrupt handler: %s.\n",
-                    str_error(rc));
-                return rc;
-        }
-
-        return EOK;
-}
-
 /** Announce OHCI root hub to the DDF
  *
@@ -184 +145 @@
 int hc_register_hub(hc_t *instance, ddf_fun_t *hub_fun)
 {
-        bool addr_reqd = false;
-        bool ep_added = false;
-        bool fun_bound = false;
-        int rc;
-
         assert(instance);
         assert(hub_fun);
@@ -194 +150 @@
         /* Try to get address 1 for root hub. */
         instance->rh.address = 1;
-        rc = usb_device_manager_request_address(
+        int ret = usb_device_manager_request_address(
             &instance->generic.dev_manager, &instance->rh.address, false,
             USB_SPEED_FULL);
-        if (rc != EOK) {
+        if (ret != EOK) {
                 usb_log_error("Failed to get OHCI root hub address: %s\n",
-                    str_error(rc));
-                goto error;
-        }
-
-        addr_reqd = true;
-
-        rc = usb_endpoint_manager_add_ep(
+                    str_error(ret));
+                return ret;
+        }
+
+#define CHECK_RET_UNREG_RETURN(ret, message...) \
+if (ret != EOK) { \
+        usb_log_error(message); \
+        usb_endpoint_manager_remove_ep( \
+            &instance->generic.ep_manager, instance->rh.address, 0, \
+            USB_DIRECTION_BOTH, NULL, NULL); \
+        usb_device_manager_release_address( \
+            &instance->generic.dev_manager, instance->rh.address); \
+        return ret; \
+} else (void)0
+
+        ret = usb_endpoint_manager_add_ep(
             &instance->generic.ep_manager, instance->rh.address, 0,
             USB_DIRECTION_BOTH, USB_TRANSFER_CONTROL, USB_SPEED_FULL, 64,
             0, NULL, NULL);
-        if (rc != EOK) {
-                usb_log_error("Failed to register root hub control endpoint: %s.\n",
-                    str_error(rc));
-                goto error;
-        }
-
-        ep_added = true;
-
-        rc = ddf_fun_add_match_id(hub_fun, "usb&class=hub", 100);
-        if (rc != EOK) {
-                usb_log_error("Failed to add root hub match-id: %s.\n",
-                    str_error(rc));
-                goto error;
-        }
-
-        rc = ddf_fun_bind(hub_fun);
-        if (rc != EOK) {
-                usb_log_error("Failed to bind root hub function: %s.\n",
-                    str_error(rc));
-                goto error;
-        }
-
-        fun_bound = true;
-
-        rc = usb_device_manager_bind_address(&instance->generic.dev_manager,
+        CHECK_RET_UNREG_RETURN(ret,
+            "Failed to register root hub control endpoint: %s.\n",
+            str_error(ret));
+
+        ret = ddf_fun_add_match_id(hub_fun, "usb&class=hub", 100);
+        CHECK_RET_UNREG_RETURN(ret,
+            "Failed to add root hub match-id: %s.\n", str_error(ret));
+
+        ret = ddf_fun_bind(hub_fun);
+        CHECK_RET_UNREG_RETURN(ret,
+            "Failed to bind root hub function: %s.\n", str_error(ret));
+
+        ret = usb_device_manager_bind_address(&instance->generic.dev_manager,
             instance->rh.address, ddf_fun_get_handle(hub_fun));
-        if (rc != EOK) {
+        if (ret != EOK)
                 usb_log_warning("Failed to bind root hub address: %s.\n",
-                    str_error(rc));
-        }
+                    str_error(ret));
 
         return EOK;
-error:
-        if (fun_bound)
-                ddf_fun_unbind(hub_fun);
-        if (ep_added) {
-                usb_endpoint_manager_remove_ep(
-                    &instance->generic.ep_manager, instance->rh.address, 0,
-                    USB_DIRECTION_BOTH, NULL, NULL);
-        }
-        if (addr_reqd) {
-                usb_device_manager_release_address(
-                    &instance->generic.dev_manager, instance->rh.address);
-        }
-        return rc;
+#undef CHECK_RET_RELEASE
 }
 
@@ -268 +208 @@
         assert(instance);
 
-        int rc =
+#define CHECK_RET_RETURN(ret, message...) \
+if (ret != EOK) { \
+        usb_log_error(message); \
+        return ret; \
+} else (void)0
+
+        int ret =
             pio_enable((void*)regs, reg_size, (void**)&instance->registers);
-        if (rc != EOK) {
-                usb_log_error("Failed to gain access to device registers: %s.\n",
-                    str_error(rc));
-                return rc;
-        }
+        CHECK_RET_RETURN(ret,
+            "Failed to gain access to device registers: %s.\n", str_error(ret));
 
         list_initialize(&instance->pending_batches);
@@ -285 +228 @@
         instance->generic.ep_remove_hook = ohci_endpoint_fini;
 
-        rc = hc_init_memory(instance);
-        if (rc != EOK) {
-                usb_log_error("Failed to create OHCI memory structures: %s.\n",
-                    str_error(rc));
-                return rc;
-        }
+        ret = hc_init_memory(instance);
+        CHECK_RET_RETURN(ret, "Failed to create OHCI memory structures: %s.\n",
+            str_error(ret));
+#undef CHECK_RET_RETURN
 
         fibril_mutex_initialize(&instance->guard);