Changes in uspace/srv/fs/ext4fs/ext4fs_ops.c [89dcf93:d1538a1] in mainline

File:

• uspace/srv/fs/ext4fs/ext4fs_ops.c (modified) (17 diffs)

uspace/srv/fs/ext4fs/ext4fs_ops.c

@@ -101 +101 @@
 static bool ext4fs_is_file(fs_node_t *node);
 static service_id_t ext4fs_service_get(fs_node_t *node);
-static int ext4fs_size_block(service_id_t, uint32_t *);
-static int ext4fs_total_block_count(service_id_t, uint64_t *);
-static int ext4fs_free_block_count(service_id_t, uint64_t *);
 
 /* Static variables */
@@ -197 +194 @@
         }
         
-        list_foreach(instance_list, link, ext4fs_instance_t, tmp) {
+        list_foreach(instance_list, link) {
+                ext4fs_instance_t *tmp =
+                    list_get_instance(link, ext4fs_instance_t, link);
+                
                 if (tmp->service_id == service_id) {
                         *inst = tmp;
@@ -259 +259 @@
         rc = ext4fs_node_get_core(rfn, eparent->instance, inode);
         if (rc != EOK)
-                goto exit;
-
-exit:
-        ;
-
+                return rc;
+        
         /* Destroy search result structure */
-        int const rc2 = ext4_directory_destroy_result(&result);
-        return rc == EOK ? rc2 : rc;
+        return ext4_directory_destroy_result(&result);
 }
 
@@ -840 +836 @@
         ext4fs_node_t *enode = EXT4FS_NODE(fn);
         return enode->instance->service_id;
-}
-
-int ext4fs_size_block(service_id_t service_id, uint32_t *size)
-{
-        ext4fs_instance_t *inst;
-        int rc = ext4fs_instance_get(service_id, &inst);
-        if (rc != EOK)
-                return rc;
-
-        if (NULL == inst)
-                return ENOENT;
-
-        ext4_superblock_t *sb = inst->filesystem->superblock;
-        *size = ext4_superblock_get_block_size(sb);
-
-        return EOK;
-}
-
-int ext4fs_total_block_count(service_id_t service_id, uint64_t *count)
-{
-        ext4fs_instance_t *inst;
-        int rc = ext4fs_instance_get(service_id, &inst);
-        if (rc != EOK)
-                return rc;
-
-        if (NULL == inst)
-                return ENOENT;
-
-        ext4_superblock_t *sb = inst->filesystem->superblock;
-        *count = ext4_superblock_get_blocks_count(sb);
-
-        return EOK;
-}
-
-int ext4fs_free_block_count(service_id_t service_id, uint64_t *count)
-{
-        ext4fs_instance_t *inst;
-        int rc = ext4fs_instance_get(service_id, &inst);
-        if (rc != EOK)
-                return rc;
-
-        ext4_superblock_t *sb = inst->filesystem->superblock;
-        *count = ext4_superblock_get_free_blocks_count(sb);
-
-        return EOK;
 }
 
@@ -906 +857 @@
         .is_directory = ext4fs_is_directory,
         .is_file = ext4fs_is_file,
-        .service_get = ext4fs_service_get,
-        .size_block = ext4fs_size_block,
-        .total_block_count = ext4fs_total_block_count,
-        .free_block_count = ext4fs_free_block_count
+        .service_get = ext4fs_service_get
 };
 
@@ -1006 +954 @@
         *lnkcnt = 1;
         
-        return ext4fs_node_put(root_node);
+        ext4fs_node_put(root_node);
+        
+        return EOK;
 }
 
@@ -1095 +1045 @@
         }
         
-        int const rc2 = ext4_filesystem_put_inode_ref(inode_ref);
-        
-        return rc == EOK ? rc2 : rc;
+        ext4_filesystem_put_inode_ref(inode_ref);
+        
+        return rc;
 }
 
@@ -1270 +1220 @@
                 memset(buffer, 0, bytes);
                 
-                rc = async_data_read_finalize(callid, buffer, bytes);
+                async_data_read_finalize(callid, buffer, bytes);
                 *rbytes = bytes;
                 
                 free(buffer);
-                return rc;
+                return EOK;
         }
         
@@ -1286 +1236 @@
         
         assert(offset_in_block + bytes <= block_size);
-        rc = async_data_read_finalize(callid, block->data + offset_in_block, bytes);
-        if (rc != EOK) {
-                block_put(block);
-                return rc;
-        }
+        async_data_read_finalize(callid, block->data + offset_in_block, bytes);
         
         rc = block_put(block);
@@ -1322 +1268 @@
         size_t len;
         if (!async_data_write_receive(&callid, &len)) {
-                rc = EINVAL;
-                async_answer_0(callid, rc);
-                goto exit;
+                ext4fs_node_put(fn);
+                async_answer_0(callid, EINVAL);
+                return EINVAL;
         }
         
@@ -1347 +1293 @@
             &fblock);
         if (rc != EOK) {
+                ext4fs_node_put(fn);
                 async_answer_0(callid, rc);
-                goto exit;
+                return rc;
         }
         
@@ -1364 +1311 @@
                                     &fblock, true);
                                 if (rc != EOK) {
+                                        ext4fs_node_put(fn);
                                         async_answer_0(callid, rc);
-                                        goto exit;
+                                        return rc;
                                 }
                         }
@@ -1372 +1320 @@
                             &fblock, false);
                         if (rc != EOK) {
+                                ext4fs_node_put(fn);
                                 async_answer_0(callid, rc);
-                                goto exit;
+                                return rc;
                         }
                 } else {
                         rc = ext4_balloc_alloc_block(inode_ref, &fblock);
                         if (rc != EOK) {
+                                ext4fs_node_put(fn);
                                 async_answer_0(callid, rc);
-                                goto exit;
+                                return rc;
                         }
                         
@@ -1386 +1336 @@
                         if (rc != EOK) {
                                 ext4_balloc_free_block(inode_ref, fblock);
+                                ext4fs_node_put(fn);
                                 async_answer_0(callid, rc);
-                                goto exit;
+                                return rc;
                         }
                 }
@@ -1399 +1350 @@
         rc = block_get(&write_block, service_id, fblock, flags);
         if (rc != EOK) {
+                ext4fs_node_put(fn);
                 async_answer_0(callid, rc);
-                goto exit;
+                return rc;
         }
         
         if (flags == BLOCK_FLAGS_NOREAD)
                 memset(write_block->data, 0, block_size);
-
+        
         rc = async_data_write_finalize(callid, write_block->data +
             (pos % block_size), bytes);
         if (rc != EOK) {
-                block_put(write_block);
-                goto exit;
-        }
-
+                ext4fs_node_put(fn);
+                return rc;
+        }
+        
         write_block->dirty = true;
-
+        
         rc = block_put(write_block);
-        if (rc != EOK)
-                goto exit;
-
+        if (rc != EOK) {
+                ext4fs_node_put(fn);
+                return rc;
+        }
+        
         /* Do some counting */
         uint32_t old_inode_size = ext4_inode_get_size(fs->superblock,
@@ -1426 +1380 @@
                 inode_ref->dirty = true;
         }
-
+        
         *nsize = ext4_inode_get_size(fs->superblock, inode_ref->inode);
         *wbytes = bytes;
-
-exit:
-        ;
-
-        int const rc2 = ext4fs_node_put(fn);
-        return rc == EOK ? rc2 : rc;
+        
+        return ext4fs_node_put(fn);
 }
 
@@ -1460 +1410 @@
         
         rc = ext4_filesystem_truncate_inode(inode_ref, new_size);
-        int const rc2 = ext4fs_node_put(fn);
-        
-        return rc == EOK ? rc2 : rc;
+        ext4fs_node_put(fn);
+        
+        return rc;
 }