Changes in uspace/drv/char/ns8250/ns8250.c [74017ce:d51838f] in mainline

File:

• uspace/drv/char/ns8250/ns8250.c (modified) (15 diffs)

uspace/drv/char/ns8250/ns8250.c

@@ -1 +1 @@
 /*
  * Copyright (c) 2010 Lenka Trochtova
- * Copyright (c) 2017 Jiri Svoboda
+ * Copyright (c) 2011 Jiri Svoboda
  * All rights reserved.
  *
@@ -53 +53 @@
 #include <ddf/interrupt.h>
 #include <ddf/log.h>
-#include <io/chardev_srv.h>
+#include <ops/char_dev.h>
 
 #include <device/hw_res.h>
@@ -153 +153 @@
         /** DDF function node */
         ddf_fun_t *fun;
-        /** Character device service */
-        chardev_srvs_t cds;
         /** Parent session */
         async_sess_t *parent_sess;
@@ -191 +189 @@
 }
 
-/** Obtain soft-state structure from chardev srv */
-static ns8250_t *srv_ns8250(chardev_srv_t *srv)
-{
-        return (ns8250_t *)srv->srvs->sarg;
-}
-
-
 /** Find out if there is some incoming data available on the serial port.
  *
@@ -243 +234 @@
 /** Read data from the serial port device.
  *
- * @param srv           Server-side connection data
+ * @param fun           The serial port function
  * @param buf           The output buffer for read data.
  * @param count         The number of bytes to be read.
- * @param nread         Place to store number of bytes actually read
- *
- * @return              EOK on success or non-zero error code
- */
-static int ns8250_read(chardev_srv_t *srv, void *buf, size_t count, size_t *nread)
-{
-        ns8250_t *ns = srv_ns8250(srv);
-        char *bp = (char *) buf;
-        size_t pos = 0;
-        
-        if (count == 0) {
-                *nread = 0;
-                return EOK;
-        }
+ *
+ * @return              The number of bytes actually read on success, negative
+ *                      error number otherwise.
+ */
+static int ns8250_read(ddf_fun_t *fun, char *buf, size_t count)
+{
+        ns8250_t *ns = fun_ns8250(fun);
+        int ret = 0;
+        
+        if (count == 0) return 0;
         
         fibril_mutex_lock(&ns->mutex);
         while (buf_is_empty(&ns->input_buffer))
                 fibril_condvar_wait(&ns->input_buffer_available, &ns->mutex);
-        while (!buf_is_empty(&ns->input_buffer) && pos < count) {
-                bp[pos] = (char)buf_pop_front(&ns->input_buffer);
-                pos++;
+        while (!buf_is_empty(&ns->input_buffer) && (size_t)ret < count) {
+                buf[ret] = (char)buf_pop_front(&ns->input_buffer);
+                ret++;
         }
         fibril_mutex_unlock(&ns->mutex);
         
-        *nread = pos;
-        return EOK;
+        return ret;
 }
 
@@ -288 +274 @@
 /** Write data to the serial port.
  *
- * @param srv           Server-side connection data
+ * @param fun           The serial port function
  * @param buf           The data to be written
  * @param count         The number of bytes to be written
- * @param nwritten      Place to store number of bytes successfully written
- * @return              EOK on success or non-zero error code
- */
-static int ns8250_write(chardev_srv_t *srv, const void *buf, size_t count,
-    size_t *nwritten)
-{
-        ns8250_t *ns = srv_ns8250(srv);
+ * @return              Zero on success
+ */
+static int ns8250_write(ddf_fun_t *fun, char *buf, size_t count)
+{
+        ns8250_t *ns = fun_ns8250(fun);
         size_t idx;
-        uint8_t *bp = (uint8_t *) buf;
         
         for (idx = 0; idx < count; idx++)
-                ns8250_putchar(ns, bp[idx]);
-        
-        *nwritten = count;
-        return EOK;
-}
-
-static int ns8250_open(chardev_srvs_t *, chardev_srv_t *);
-static int ns8250_close(chardev_srv_t *);
-static void ns8250_default_handler(chardev_srv_t *, ipc_callid_t, ipc_call_t *);
+                ns8250_putchar(ns, (uint8_t) buf[idx]);
+        
+        return count;
+}
+
+static ddf_dev_ops_t ns8250_dev_ops;
 
 /** The character interface's callbacks. */
-static chardev_ops_t ns8250_chardev_ops = {
-        .open = ns8250_open,
-        .close = ns8250_close,
-        .read = ns8250_read,
-        .write = ns8250_write,
-        .def_handler = ns8250_default_handler
+static char_dev_ops_t ns8250_char_dev_ops = {
+        .read = &ns8250_read,
+        .write = &ns8250_write
 };
-
-static void ns8250_char_conn(ipc_callid_t, ipc_call_t *, void *);
 
 static int ns8250_dev_add(ddf_dev_t *dev);
@@ -897 +872 @@
         }
         
-        ddf_fun_set_conn_handler(fun, ns8250_char_conn);
-        
-        chardev_srvs_init(&ns->cds);
-        ns->cds.ops = &ns8250_chardev_ops;
-        ns->cds.sarg = ns;
-        
+        /* Set device operations. */
+        ddf_fun_set_ops(fun, &ns8250_dev_ops);
         rc = ddf_fun_bind(fun);
         if (rc != EOK) {
@@ -959 +930 @@
  * device.
  *
- * @param srvs          Service structure
- * @param srv           Server-side connection structure
- */
-static int ns8250_open(chardev_srvs_t *srvs, chardev_srv_t *srv)
-{
-        ns8250_t *ns = srv_ns8250(srv);
+ * @param dev           The device.
+ */
+static int ns8250_open(ddf_fun_t *fun)
+{
+        ns8250_t *ns = fun_ns8250(fun);
         int res;
         
@@ -984 +954 @@
  * the device.
  *
- * @param srv           Server-side connection structure
- */
-static int ns8250_close(chardev_srv_t *srv)
-{
-        ns8250_t *data = srv_ns8250(srv);
+ * @param dev           The device.
+ */
+static void ns8250_close(ddf_fun_t *fun)
+{
+        ns8250_t *data = fun_ns8250(fun);
         
         fibril_mutex_lock(&data->mutex);
@@ -998 +968 @@
         
         fibril_mutex_unlock(&data->mutex);
-        
-        return EOK;
 }
 
@@ -1066 +1034 @@
  * Configure the parameters of the serial communication.
  */
-static void ns8250_default_handler(chardev_srv_t *srv, ipc_callid_t callid,
+static void ns8250_default_handler(ddf_fun_t *fun, ipc_callid_t callid,
     ipc_call_t *call)
 {
-        ns8250_t *ns8250 = srv_ns8250(srv);
         sysarg_t method = IPC_GET_IMETHOD(*call);
         int ret;
@@ -1076 +1043 @@
         switch (method) {
         case SERIAL_GET_COM_PROPS:
-                ns8250_get_props(ns8250->dev, &baud_rate, &parity, &word_length,
+                ns8250_get_props(ddf_fun_get_dev(fun), &baud_rate, &parity, &word_length,
                     &stop_bits);
                 async_answer_4(callid, EOK, baud_rate, parity, word_length,
@@ -1087 +1054 @@
                 word_length = IPC_GET_ARG3(*call);
                 stop_bits = IPC_GET_ARG4(*call);
-                ret = ns8250_set_props(ns8250->dev, baud_rate, parity, word_length,
+                ret = ns8250_set_props(ddf_fun_get_dev(fun), baud_rate, parity, word_length,
                     stop_bits);
                 async_answer_0(callid, ret);
@@ -1097 +1064 @@
 }
 
-void ns8250_char_conn(ipc_callid_t iid, ipc_call_t *icall, void *arg)
-{
-        ns8250_t *ns8250 = fun_ns8250((ddf_fun_t *)arg);
-
-        chardev_conn(iid, icall, &ns8250->cds);
-}
-
 /** Initialize the serial port driver.
  *
@@ -1112 +1072 @@
 {
         ddf_log_init(NAME);
+        
+        ns8250_dev_ops.open = &ns8250_open;
+        ns8250_dev_ops.close = &ns8250_close;
+        
+        ns8250_dev_ops.interfaces[CHAR_DEV_IFACE] = &ns8250_char_dev_ops;
+        ns8250_dev_ops.default_handler = &ns8250_default_handler;
 }