Changes in uspace/app/taskdump/taskdump.c [7354b5e:d5c1051] in mainline

File:

• uspace/app/taskdump/taskdump.c (modified) (17 diffs)

uspace/app/taskdump/taskdump.c

@@ -40 +40 @@
 #include <stddef.h>
 #include <stdbool.h>
+#include <str_error.h>
 #include <errno.h>
 #include <udebug.h>
@@ -91 +92 @@
 
         rc = connect_task(task_id);
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("Failed connecting to task %" PRIu64 ".\n", task_id);
                 return 1;
@@ -104 +105 @@
 
         rc = threads_dump();
-        if (rc < 0)
+        if (rc != EOK)
                 printf("Failed dumping threads.\n");
 
         rc = areas_dump();
-        if (rc < 0)
+        if (rc != EOK)
                 printf("Failed dumping address space areas.\n");
 
         rc = fibrils_dump(app_symtab, sess);
-        if (rc < 0)
+        if (rc != EOK)
                 printf("Failed dumping fibrils.\n");
 
@@ -135 +136 @@
                 
                 printf("Error connecting\n");
-                printf("async_connect_kbox(%" PRIu64 ") -> %d ", task_id, errno);
+                printf("async_connect_kbox(%" PRIu64 ") -> %s", task_id, str_error_name(errno));
                 return errno;
         }
         
         int rc = udebug_begin(ksess);
-        if (rc < 0) {
-                printf("udebug_begin() -> %d\n", rc);
+        if (rc != EOK) {
+                printf("udebug_begin() -> %s\n", str_error_name(rc));
                 return rc;
         }
@@ -222 +223 @@
         /* TODO: See why NULL does not work. */
         rc = udebug_thread_read(sess, &dummy_buf, 0, &copied, &needed);
-        if (rc < 0) {
-                printf("udebug_thread_read() -> %d\n", rc);
+        if (rc != EOK) {
+                printf("udebug_thread_read() -> %s\n", str_error_name(rc));
                 return rc;
         }
@@ -236 +237 @@
 
         rc = udebug_thread_read(sess, thash_buf, buf_size, &copied, &needed);
-        if (rc < 0) {
-                printf("udebug_thread_read() -> %d\n", rc);
+        if (rc != EOK) {
+                printf("udebug_thread_read() -> %s\n", str_error_name(rc));
                 return rc;
         }
@@ -271 +272 @@
 
         rc = udebug_areas_read(sess, &dummy_buf, 0, &copied, &needed);
-        if (rc < 0) {
-                printf("udebug_areas_read() -> %d\n", rc);
+        if (rc != EOK) {
+                printf("udebug_areas_read() -> %s\n", str_error_name(rc));
                 return rc;
         }
@@ -280 +281 @@
 
         rc = udebug_areas_read(sess, ainfo_buf, buf_size, &copied, &needed);
-        if (rc < 0) {
-                printf("udebug_areas_read() -> %d\n", rc);
+        if (rc != EOK) {
+                printf("udebug_areas_read() -> %s\n", str_error_name(rc));
                 return rc;
         }
@@ -356 +357 @@
 
         rc = udebug_regs_read(sess, thash, &istate);
-        if (rc < 0) {
-                printf("Failed reading registers (%d).\n", rc);
+        if (rc != EOK) {
+                printf("Failed reading registers: %s.\n", str_error_name(rc));
                 return EIO;
         }
@@ -385 +386 @@
 
         rc = udebug_mem_read(sess, &data, addr, sizeof(data));
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("Warning: udebug_mem_read() failed.\n");
                 return rc;
@@ -399 +400 @@
         char *file_name;
         int rc;
+        int ret;
 
         assert(app_name != NULL);
         assert(app_symtab == NULL);
 
-        rc = asprintf(&file_name, "/app/%s", app_name);
-        if (rc < 0) {
+        ret = asprintf(&file_name, "/app/%s", app_name);
+        if (ret < 0) {
                 printf("Memory allocation failure.\n");
                 exit(1);
@@ -418 +420 @@
         free(file_name);
 
-        rc = asprintf(&file_name, "/srv/%s", app_name);
-        if (rc < 0) {
+        ret = asprintf(&file_name, "/srv/%s", app_name);
+        if (ret < 0) {
                 printf("Memory allocation failure.\n");
                 exit(1);
@@ -431 +433 @@
         }
 
-        rc = asprintf(&file_name, "/drv/%s/%s", app_name, app_name);
-        if (rc < 0) {
+        ret = asprintf(&file_name, "/drv/%s/%s", app_name, app_name);
+        if (ret < 0) {
                 printf("Memory allocation failure.\n");
                 exit(1);
@@ -456 +458 @@
 
         rc = udebug_name_read(sess, &dummy_buf, 0, &copied, &needed);
-        if (rc < 0)
+        if (rc != EOK)
                 return NULL;
 
@@ -462 +464 @@
         name = malloc(name_size + 1);
         rc = udebug_name_read(sess, name, name_size, &copied, &needed);
-        if (rc < 0) {
+        if (rc != EOK) {
                 free(name);
                 return NULL;
@@ -487 +489 @@
         size_t offs;
         int rc;
+        int ret;
         char *str;
 
@@ -496 +499 @@
 
         if (rc == EOK) {
-                rc = asprintf(&str, "%p (%s+%zu)", (void *) addr, name, offs);
+                ret = asprintf(&str, "%p (%s+%zu)", (void *) addr, name, offs);
         } else {
-                rc = asprintf(&str, "%p", (void *) addr);
-        }
-
-        if (rc < 0) {
+                ret = asprintf(&str, "%p", (void *) addr);
+        }
+
+        if (ret < 0) {
                 printf("Memory allocation error.\n");
                 exit(1);