Changeset d70e0a3c in mainline for uspace/drv/usbmid/explore.c

Timestamp:

2011-03-02T18:17:27Z (14 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a6567ed

Parents:

4723444

Message:

Allocating "get full config desc" put into action

Yes, all that removed code is now replaced with a single function.
And yes, it was the same in all drivers.

File:

• uspace/drv/usbmid/explore.c (modified) (2 diffs)

uspace/drv/usbmid/explore.c

@@ -42 +42 @@
 #include "usbmid.h"
 
-/** Allocate and retrieve full configuration descriptor.
- *
- * @param[in] dev USB device.
- * @param[in] config_index Configuration index.
- * @param[out] size Pointer where to store size of the allocated buffer.
- * @return Allocated full configuration descriptor.
- * @retval NULL Error occured.
- */
-static void *get_configuration_descriptor(usbmid_device_t *dev,
-    size_t config_index, size_t *size)
-{
-        usb_standard_configuration_descriptor_t config_descriptor;
-        int rc = usb_request_get_bare_configuration_descriptor(&dev->ctrl_pipe,
-            config_index, &config_descriptor);
-        if (rc != EOK) {
-                usb_log_error("Failed getting configuration descriptor: %s.\n",
-                    str_error(rc));
-                return NULL;
-        }
-
-        void *full_config_descriptor = malloc(config_descriptor.total_length);
-        if (full_config_descriptor == NULL) {
-                usb_log_fatal("Out of memory (wanted: %zuB).\n",
-                    (size_t) config_descriptor.total_length);
-                return NULL;
-        }
-
-        size_t full_config_descriptor_size;
-        rc = usb_request_get_full_configuration_descriptor(&dev->ctrl_pipe,
-            config_index,
-            full_config_descriptor, config_descriptor.total_length,
-            &full_config_descriptor_size);
-        if (rc != EOK) {
-                usb_log_error("Failed getting configuration descriptor: %s.\n",
-                    str_error(rc));
-                free(full_config_descriptor);
-                return NULL;
-        }
-
-        if (full_config_descriptor_size != config_descriptor.total_length) {
-                usb_log_error("Failed getting full configuration descriptor.\n");
-                free(full_config_descriptor);
-                return NULL;
-        }
-
-        if (size != NULL) {
-                *size = full_config_descriptor_size;
-        }
-
-        return full_config_descriptor;
-}
-
 /** Find starting indexes of all interface descriptors in a configuration.
  *
@@ -178 +126 @@
 
         size_t config_descriptor_size;
-        uint8_t *config_descriptor_raw = get_configuration_descriptor(dev, 0,
-            &config_descriptor_size);
-        if (config_descriptor_raw == NULL) {
+        uint8_t *config_descriptor_raw = NULL;
+        rc = usb_request_get_full_configuration_descriptor_alloc(
+            &dev->ctrl_pipe, 0,
+            (void **) &config_descriptor_raw, &config_descriptor_size);
+        if (rc != EOK) {
+                usb_log_error("Failed getting full config descriptor: %s.\n",
+                    str_error(rc));
                 return false;
         }