Changeset d8b42fb2 in mainline

Timestamp:

2006-06-19T10:10:00Z (19 years ago)

Author:

Ondrej Palkovsky <ondrap@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

09087d2

Parents:

231a60a

Message:

Sligtly more efficient ipc.

Files:

• console/gcons.c (modified) (1 diff)
• libc/generic/ipc.c (modified) (4 diffs)

console/gcons.c

@@ -230 +230 @@
 }
 
-
+/** Return x, where left <= x <= right && |a-x|==min(|a-x|) is smallest */
 static inline int limit(int a,int left, int right)
 {

libc/generic/ipc.c

@@ -150 +150 @@
                                     async_call_t *call, int can_preempt)
 {
+        if (!call) { /* Nothing to do regardless if failed or not */
+                futex_up(&ipc_futex);
+                return;
+        }
+
         if (callid == IPC_CALLRET_FATAL) {
                 futex_up(&ipc_futex);
@@ -193 +198 @@
                       ipc_async_callback_t callback, int can_preempt)
 {
-        async_call_t *call;
-        ipc_callid_t callid;
-
-        call = ipc_prepare_async(private, callback);
-        if (!call)
-                return;
+        async_call_t *call = NULL;
+        ipc_callid_t callid;
+
+        if (callback) {
+                call = ipc_prepare_async(private, callback);
+                if (!call)
+                        return;
+        }
 
         /* We need to make sure that we get callid before
@@ -206 +213 @@
 
         if (callid == IPC_CALLRET_TEMPORARY) {
+                if (!call) {
+                        call = ipc_prepare_async(private, callback);
+                        if (!call)
+                                return;
+                }
                 IPC_SET_METHOD(call->u.msg.data, method);
                 IPC_SET_ARG1(call->u.msg.data, arg1);
@@ -343 +355 @@
         }
         futex_up(&ipc_futex);
-        printf("Received unidentified answer: %P!!!\n", callid);
+        /* We may get here after async_msg, which doesn't register any callback */
 }