Changeset d9fae235 in mainline for uspace/srv/hid/kbd/port/ns16550.c

Timestamp:

2010-04-17T01:28:38Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9d6bfa5

Parents:

9256ad29

Message:

sysinfo overhaul

• cleanup (nicer data structures, use of SLAB allocator)
• add support for storing arbitrary binary data
• properly reimplement non-constant values (generated by functions)
• add support for non-constant subtrees (generated by functions)
• syscall ABI change, libc API change
• reflect changes in user code

libc: task_spawn() can now return error code

• reflect change in user code, print error strings after failed task_spawn()

uspace cleanup

• more use of string and other constants
• more use of str_error()
• unify error reporting in init

File:

• uspace/srv/hid/kbd/port/ns16550.c (modified) (4 diffs)

uspace/srv/hid/kbd/port/ns16550.c

@@ -30 +30 @@
  * @ingroup  kbd
  * @{
- */ 
+ */
 /** @file
- * @brief       NS16550 port driver.
+ * @brief NS16550 port driver.
  */
 
@@ -43 +43 @@
 #include <sun.h>
 #include <ddi.h>
+#include <errno.h>
 
 /* NS16550 registers */
-#define RBR_REG         0       /** Receiver Buffer Register. */
-#define IER_REG         1       /** Interrupt Enable Register. */
-#define IIR_REG         2       /** Interrupt Ident Register (read). */
-#define FCR_REG         2       /** FIFO control register (write). */
-#define LCR_REG         3       /** Line Control register. */
-#define MCR_REG         4       /** Modem Control Register. */
-#define LSR_REG         5       /** Line Status Register. */
+#define RBR_REG  0  /** Receiver Buffer Register. */
+#define IER_REG  1  /** Interrupt Enable Register. */
+#define IIR_REG  2  /** Interrupt Ident Register (read). */
+#define FCR_REG  2  /** FIFO control register (write). */
+#define LCR_REG  3  /** Line Control register. */
+#define MCR_REG  4  /** Modem Control Register. */
+#define LSR_REG  5  /** Line Status Register. */
 
-#define LSR_DATA_READY  0x01
+#define LSR_DATA_READY  0x01
 
 static irq_cmd_t ns16550_cmds[] = {
         {
                 .cmd = CMD_PIO_READ_8,
-                .addr = (void *) 0,     /* will be patched in run-time */
+                .addr = (void *) 0,     /* Will be patched in run-time */
                 .dstarg = 1
         },
@@ -74 +75 @@
         {
                 .cmd = CMD_PIO_READ_8,
-                .addr = (void *) 0,     /* will be patched in run-time */
+                .addr = (void *) 0,     /* Will be patched in run-time */
                 .dstarg = 2
         },
@@ -96 +97 @@
         void *vaddr;
 
-        async_set_interrupt_received(ns16550_irq_handler);
-
-        ns16550_physical = sysinfo_value("kbd.address.physical");
-        ns16550_kernel = sysinfo_value("kbd.address.kernel");
+        if (sysinfo_get_value("kbd.address.physical", &ns16550_physical) != EOK)
+                return -1;
+        
+        if (sysinfo_get_value("kbd.address.kernel", &ns16550_kernel) != EOK)
+                return -1;
+        
+        sysarg_t inr;
+        if (sysinfo_get_value("kbd.inr", &inr) != EOK)
+                return -1;
+        
         ns16550_kbd.cmds[0].addr = (void *) (ns16550_kernel + LSR_REG);
         ns16550_kbd.cmds[3].addr = (void *) (ns16550_kernel + RBR_REG);
-        ipc_register_irq(sysinfo_value("kbd.inr"), device_assign_devno(),
-            sysinfo_value("kbd.inr"), &ns16550_kbd);
+        
+        async_set_interrupt_received(ns16550_irq_handler);
+        ipc_register_irq(inr, device_assign_devno(), inr, &ns16550_kbd);
+        
         return pio_enable((void *) ns16550_physical, 8, &vaddr);
 }