Changeset d9fae235 in mainline for uspace/srv/hid/kbd/port/pl050.c

Timestamp:

2010-04-17T01:28:38Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9d6bfa5

Parents:

9256ad29

Message:

sysinfo overhaul

• cleanup (nicer data structures, use of SLAB allocator)
• add support for storing arbitrary binary data
• properly reimplement non-constant values (generated by functions)
• add support for non-constant subtrees (generated by functions)
• syscall ABI change, libc API change
• reflect changes in user code

libc: task_spawn() can now return error code

• reflect change in user code, print error strings after failed task_spawn()

uspace cleanup

• more use of string and other constants
• more use of str_error()
• unify error reporting in init

File:

• uspace/srv/hid/kbd/port/pl050.c (modified) (1 diff)

uspace/srv/hid/kbd/port/pl050.c

@@ -83 +83 @@
 int kbd_port_init(void)
 {
-
-        pl050_kbd.cmds[0].addr = (void *) sysinfo_value("kbd.address.status");
-        pl050_kbd.cmds[3].addr = (void *) sysinfo_value("kbd.address.data");
-
+        if (sysinfo_get_value("kbd.address.status", &pl050_kbd.cmds[0].addr) != EOK)
+                return -1;
+        
+        if (sysinfo_get_value("kbd.address.data", &pl050_kbd.cmds[3].addr) != EOK)
+                return -1;
+        
+        sysarg_t inr;
+        if (sysinfo_get_value("kbd.inr", &inr) != EOK)
+                return -1;
+        
         async_set_interrupt_received(pl050_irq_handler);
-
-        ipc_register_irq(sysinfo_value("kbd.inr"), device_assign_devno(), 0, &pl050_kbd);
-
+        ipc_register_irq(inr, device_assign_devno(), 0, &pl050_kbd);
+        
         return 0;
 }