Changeset da1bafb in mainline for kernel/generic/src/mm/page.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/generic/src/mm/page.c (modified) (9 diffs)

kernel/generic/src/mm/page.c

@@ -33 +33 @@
 /**
  * @file
- * @brief       Virtual Address Translation subsystem.
+ * @brief Virtual Address Translation subsystem.
  *
  * This file contains code for creating, destroying and searching
@@ -39 +39 @@
  * Functions here are mere wrappers that call the real implementation.
  * They however, define the single interface. 
+ *
  */
 
@@ -55 +56 @@
  * will do an implicit serialization by virtue of running the TLB shootdown
  * interrupt handler.
+ *
  */
 
@@ -83 +85 @@
  * of page boundaries.
  *
- * @param s             Address of the structure.
- * @param size          Size of the structure.
+ * @param addr Address of the structure.
+ * @param size Size of the structure.
+ *
  */
-void map_structure(uintptr_t s, size_t size)
+void map_structure(uintptr_t addr, size_t size)
 {
-        int i, cnt, length;
-
-        length = size + (s - (s & ~(PAGE_SIZE - 1)));
-        cnt = length / PAGE_SIZE + (length % PAGE_SIZE > 0);
-
+        size_t length = size + (addr - (addr & ~(PAGE_SIZE - 1)));
+        size_t cnt = length / PAGE_SIZE + (length % PAGE_SIZE > 0);
+        
+        size_t i;
         for (i = 0; i < cnt; i++)
-                page_mapping_insert(AS_KERNEL, s + i * PAGE_SIZE,
-                    s + i * PAGE_SIZE, PAGE_NOT_CACHEABLE | PAGE_WRITE);
-
+                page_mapping_insert(AS_KERNEL, addr + i * PAGE_SIZE,
+                    addr + i * PAGE_SIZE, PAGE_NOT_CACHEABLE | PAGE_WRITE);
+        
         /* Repel prefetched accesses to the old mapping. */
         memory_barrier();
@@ -108 +110 @@
  * The page table must be locked and interrupts must be disabled.
  *
- * @param as            Address space to wich page belongs.
- * @param page          Virtual address of the page to be mapped.
- * @param frame         Physical address of memory frame to which the mapping is
- *                      done.
- * @param flags         Flags to be used for mapping.
+ * @param as    Address space to wich page belongs.
+ * @param page  Virtual address of the page to be mapped.
+ * @param frame Physical address of memory frame to which the mapping is
+ *              done.
+ * @param flags Flags to be used for mapping.
+ *
  */
-void page_mapping_insert(as_t *as, uintptr_t page, uintptr_t frame, int flags)
+void page_mapping_insert(as_t *as, uintptr_t page, uintptr_t frame,
+    unsigned int flags)
 {
         ASSERT(page_mapping_operations);
@@ -133 +137 @@
  * The page table must be locked and interrupts must be disabled.
  *
- * @param as            Address space to wich page belongs.
- * @param page          Virtual address of the page to be demapped.
+ * @param as   Address space to wich page belongs.
+ * @param page Virtual address of the page to be demapped.
+ *
  */
 void page_mapping_remove(as_t *as, uintptr_t page)
@@ -142 +147 @@
         
         page_mapping_operations->mapping_remove(as, page);
-
+        
         /* Repel prefetched accesses to the old mapping. */
         memory_barrier();
@@ -153 +158 @@
  * The page table must be locked and interrupts must be disabled.
  *
- * @param as            Address space to wich page belongs.
- * @param page          Virtual page.
+ * @param as   Address space to wich page belongs.
+ * @param page Virtual page.
  *
- * @return              NULL if there is no such mapping; requested mapping
- *                      otherwise.
+ * @return NULL if there is no such mapping; requested mapping
+ *         otherwise.
+ *
  */
 pte_t *page_mapping_find(as_t *as, uintptr_t page)
@@ -163 +169 @@
         ASSERT(page_mapping_operations);
         ASSERT(page_mapping_operations->mapping_find);
-
+        
         return page_mapping_operations->mapping_find(as, page);
 }