Changeset dd7df1c in mainline

Timestamp:

2023-10-22T17:26:17Z (13 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

dcef1127

Parents:

71b4444

git-author:

Vojtech Horky <vojtech.horky@…> (2023-07-14 09:54:21)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-10-22 17:26:17)

Message:

Silence spurious/unwanted GCC warnings using pragmas

Location:

uspace

Files:

• app/tester/fault/fault1.c (modified) (1 diff)
• app/tester/print/print5.c (modified) (1 diff)
• lib/c/generic/rtld/symbol.c (modified) (1 diff)
• lib/c/test/string.c (modified) (1 diff)
• srv/hid/display/test/window.c (modified) (2 diffs)

uspace/app/tester/fault/fault1.c

@@ -30 +30 @@
 #include "../tester.h"
 
+#pragma GCC diagnostic ignored "-Warray-bounds"
+
 const char *test_fault1(void)
 {

uspace/app/tester/print/print5.c

@@ -38 +38 @@
  */
 #pragma GCC diagnostic ignored "-Wformat"
+#pragma GCC diagnostic ignored "-Wformat-overflow"
 
 #include <stdio.h>

uspace/lib/c/generic/rtld/symbol.c

@@ -135 +135 @@
         modules_untag(start->rtld);
 
-        /* Insert root (the program) into the queue and tag it */
+        /*
+         * Insert root (the program) into the queue and tag it.
+         *
+         * We disable the dangling-pointer warning because the compiler incorrectly
+         * assumes that we leak local address (queue) to a parent scope (to start
+         * argument). However, we always empty the list so the pointer cannot
+         * actually escape. Probably the compiler can never statically analyze that
+         * correctly.
+         */
         list_initialize(&queue);
         start->bfs_tag = true;
+#pragma GCC diagnostic push
+#if defined(__GNUC__) && (__GNUC__ >= 12)
+#pragma GCC diagnostic ignored "-Wdangling-pointer"
+#endif
         list_append(&start->queue_link, &queue);
+#pragma GCC diagnostic pop
 
         /* If the symbol is found, it will be stored in 'sym' */

uspace/lib/c/test/string.c

@@ -799 +799 @@
 PCUT_TEST(strndup_nonempty_short)
 {
+#pragma GCC diagnostic push
+        // Intentionally checking it works with _longer_ size than actual
+#if defined(__GNUC__) && (__GNUC__ >= 11)
+#pragma GCC diagnostic ignored "-Wstringop-overread"
+#endif
         char *d = strndup("abc", 5);
+#pragma GCC diagnostic pop
         PCUT_ASSERT_NOT_NULL(d);
         PCUT_ASSERT_TRUE(d[0] == 'a');

uspace/srv/hid/display/test/window.c

@@ -1109 +1109 @@
         PCUT_ASSERT_EQUALS(wnd->display->cursor[dcurs_arrow], wnd->cursor);
 
+        // Check that invalid cursors cannot be set: ignore enum conversions
+        // as we are out-of-bounds
+#pragma GCC diagnostic push
+#if defined(__GNUC__) && (__GNUC__ >= 10)
+#pragma GCC diagnostic ignored "-Wenum-conversion"
+#endif
         rc = ds_window_set_cursor(wnd, dcurs_limit);
         PCUT_ASSERT_ERRNO_VAL(EINVAL, rc);
@@ -1116 +1122 @@
         PCUT_ASSERT_ERRNO_VAL(EINVAL, rc);
         PCUT_ASSERT_EQUALS(wnd->display->cursor[dcurs_arrow], wnd->cursor);
+#pragma GCC diagnostic pop
 
         rc = ds_window_set_cursor(wnd, dcurs_size_lr);