Changeset e811bde in mainline

Timestamp:

2008-05-17T21:04:01Z (17 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ce7311fc

Parents:

add5835

Message:

Add synchronization to fat_match().

File:

• uspace/srv/fs/fat/fat_ops.c (modified) (4 diffs)

uspace/srv/fs/fat/fat_ops.c

@@ -392 +392 @@
         block_t *b;
 
+        futex_down(&parentp->idx->lock);
         bps = fat_bps_get(parentp->idx->dev_handle);
         dps = bps / sizeof(fat_dentry_t);
@@ -409 +410 @@
                         case FAT_DENTRY_LAST:
                                 block_put(b);
+                                futex_up(&parentp->idx->lock);
                                 return NULL;
                         default:
@@ -418 +420 @@
                                 /* hit */
                                 void *node;
+                                /*
+                                 * Assume tree hierarchy for locking.  We
+                                 * already have the parent and now we are going
+                                 * to lock the child.  Never lock in the oposite
+                                 * order.
+                                 */
                                 fat_idx_t *idx = fat_idx_get_by_pos(
                                     parentp->idx->dev_handle, parentp->firstc,
                                     i * dps + j);
+                                futex_up(&parentp->idx->lock);
                                 if (!idx) {
                                         /*
@@ -437 +446 @@
                 block_put(b);
         }
-
+        futex_up(&parentp->idx->lock);
         return NULL;
 }