Changeset e8d5f9f in mainline for uspace/srv/vfs/vfs_file.c

Timestamp:

2011-05-31T23:11:28Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5d1b3aa

Parents:

4ce90544 (diff), 25bef0ff (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge from lp:~jakub/helenos/fs.

File:

• uspace/srv/vfs/vfs_file.c (modified) (5 diffs)

uspace/srv/vfs/vfs_file.c

@@ -79 +79 @@
         for (i = 0; i < MAX_OPEN_FILES; i++) {
                 if (FILES[i]) {
-                        (void) vfs_close_internal(FILES[i]);
                         (void) vfs_fd_free(i);
                 }
@@ -108 +107 @@
 }
 
+/** Close the file in the endpoint FS server. */
+static int vfs_file_close_remote(vfs_file_t *file)
+{
+        ipc_call_t answer;
+        aid_t msg;
+        sysarg_t rc;
+        int phone;
+
+        assert(!file->refcnt);
+
+        phone = vfs_grab_phone(file->node->fs_handle);
+        msg = async_send_2(phone, VFS_OUT_CLOSE, file->node->devmap_handle,
+            file->node->index, &answer);
+        async_wait_for(msg, &rc);
+        vfs_release_phone(file->node->fs_handle, phone);
+
+        return IPC_GET_ARG1(answer);
+}
+
+
 /** Increment reference count of VFS file structure.
  *
@@ -125 +144 @@
  *                      decremented.
  */
-static void vfs_file_delref(vfs_file_t *file)
-{
+static int vfs_file_delref(vfs_file_t *file)
+{
+        int rc = EOK;
+
         assert(fibril_mutex_is_locked(&VFS_DATA->lock));
 
         if (file->refcnt-- == 1) {
                 /*
-                 * Lost the last reference to a file, need to drop our reference
-                 * to the underlying VFS node.
+                 * Lost the last reference to a file, need to close it in the
+                 * endpoint FS and drop our reference to the underlying VFS node.
                  */
+                rc = vfs_file_close_remote(file);
                 vfs_node_delref(file->node);
                 free(file);
         }
+
+        return rc;
 }
 
@@ -201 +225 @@
 int vfs_fd_free(int fd)
 {
+        int rc;
+
         if (!vfs_files_init())
                 return ENOMEM;
@@ -210 +236 @@
         }
         
-        vfs_file_delref(FILES[fd]);
+        rc = vfs_file_delref(FILES[fd]);
         FILES[fd] = NULL;
         fibril_mutex_unlock(&VFS_DATA->lock);
         
-        return EOK;
+        return rc;
 }