Changes in kernel/arch/amd64/src/asm.S [4236b18:e98f1c3e] in mainline

File:

• kernel/arch/amd64/src/asm.S (modified) (14 diffs)

kernel/arch/amd64/src/asm.S

@@ -27 +27 @@
  */
 
+#include <abi/asmtool.h>
 #include <arch/pm.h>
 #include <arch/mm/page.h>
 #include <arch/istate_struct.h>
+#include <arch/kseg_struct.h>
+#include <arch/cpu.h>
+#include <arch/smp/apic.h>
 
 .text
-.global interrupt_handlers
-.global syscall_entry
-.global cpuid
-.global has_cpuid
-.global read_efer_flag
-.global set_efer_flag
-.global memcpy_from_uspace
-.global memcpy_to_uspace
-.global memcpy_from_uspace_failover_address
-.global memcpy_to_uspace_failover_address
-.global early_putchar
 
 #define MEMCPY_DST   %rdi
@@ -64 +57 @@
  *
  */
-memcpy_from_uspace:
-memcpy_to_uspace:
+FUNCTION_BEGIN(memcpy_from_uspace)
+FUNCTION_BEGIN(memcpy_to_uspace)
         movq MEMCPY_DST, %rax
         
@@ -81 +74 @@
         0:
                 ret                 /* return MEMCPY_SRC, success */
-
-memcpy_from_uspace_failover_address:
-memcpy_to_uspace_failover_address:
+FUNCTION_END(memcpy_from_uspace)
+FUNCTION_END(memcpy_to_uspace)
+
+SYMBOL(memcpy_from_uspace_failover_address)
+SYMBOL(memcpy_to_uspace_failover_address)
         xorl %eax, %eax         /* return 0, failure */
         ret
@@ -92 +87 @@
 *
 */
-has_cpuid:
+FUNCTION_BEGIN(has_cpuid)
         /* Load RFLAGS */
         pushfq
@@ -99 +94 @@
         
         /* Flip the ID bit */
-        btcl $21, %edx
+        xorl $RFLAGS_ID, %edx
         
         /* Store RFLAGS */
@@ -108 +103 @@
         /* Get the ID bit again */
         popq %rdx
-        andl $(1 << 21), %eax
-        andl $(1 << 21), %edx
+        andl $RFLAGS_ID, %eax
+        andl $RFLAGS_ID, %edx
         
         /* 0 if not supported, 1 if supported */
         xorl %edx, %eax
         ret
-
-cpuid:
+FUNCTION_END(has_cpuid)
+
+FUNCTION_BEGIN(cpuid)
         /* Preserve %rbx across function calls */
         movq %rbx, %r10
@@ -130 +126 @@
         movq %r10, %rbx
         ret
-
-set_efer_flag:
-        movl $0xc0000080, %ecx
+FUNCTION_END(cpuid)
+
+/** Enable local APIC
+ *
+ * Enable local APIC in MSR.
+ *
+ */
+FUNCTION_BEGIN(enable_l_apic_in_msr)
+        movl $AMD_MSR_APIC_BASE, %ecx
         rdmsr
-        btsl %edi, %eax
+        orl $(L_APIC_BASE | AMD_APIC_BASE_GE), %eax
         wrmsr
         ret
-
-read_efer_flag:
-        movl $0xc0000080, %ecx
-        rdmsr
-        ret
+FUNCTION_END(enable_l_apic_in_msr)
 
 /*
@@ -157 +155 @@
 
 .macro handler i
-.global int_\i
-int_\i:
+SYMBOL(int_\i)
 
         /*
@@ -204 +201 @@
 
         /*
+         * Is this trap from the kernel?
+         */
+        cmpq $(GDT_SELECTOR(KTEXT_DES)), ISTATE_OFFSET_CS(%rsp)
+        jz 0f
+
+        /*
+         * Switch to kernel FS base.
+         */
+        swapgs
+        movl $AMD_MSR_FS, %ecx
+        movl %gs:KSEG_OFFSET_FSBASE, %eax
+        movl %gs:KSEG_OFFSET_FSBASE+4, %edx
+        wrmsr
+        swapgs
+
+        /*
          * Imitate a regular stack frame linkage.
          * Stop stack traces here if we came from userspace.
          */
-        xorl %edx, %edx
-        cmpq $(GDT_SELECTOR(KTEXT_DES)), ISTATE_OFFSET_CS(%rsp)
+0:      movl $0x0, %edx
         cmovnzq %rdx, %rbp
 
@@ -249 +261 @@
         53,54,55,56,57,58,59,60,61,62,63
 
-interrupt_handlers:
+SYMBOL(interrupt_handlers)
 .irp cnt, LIST_0_63
         handler \cnt 
@@ -273 +285 @@
  *
  */
-syscall_entry:
+SYMBOL(syscall_entry)
         /* Switch to hidden %gs */
         swapgs
         
-        /*
-         * %gs:0 Scratch space for this thread's user RSP
-         * %gs:8 Address to be used as this thread's kernel RSP
-         */
-        
-        movq %rsp, %gs:0  /* save this thread's user RSP */
-        movq %gs:8, %rsp  /* set this thread's kernel RSP */
-        
+        movq %rsp, %gs:KSEG_OFFSET_USTACK_RSP  /* save this thread's user RSP */
+        movq %gs:KSEG_OFFSET_KSTACK_RSP, %rsp  /* set this thread's kernel RSP */
+
         /*
          * Note that the space needed for the imitated istate structure has been
@@ -313 +320 @@
 
         /*
+         * Switch to kernel FS base.
+         */
+        movl $AMD_MSR_FS, %ecx
+        movl %gs:KSEG_OFFSET_FSBASE, %eax
+        movl %gs:KSEG_OFFSET_FSBASE+4, %edx
+        wrmsr
+        movq ISTATE_OFFSET_RDX(%rsp), %rdx      /* restore 3rd argument */
+
+        /*
          * Save the return address and the userspace stack on locations that
          * would normally be taken by them.
          */
-        movq %gs:0, %rax
+        movq %gs:KSEG_OFFSET_USTACK_RSP, %rax
         movq %rax, ISTATE_OFFSET_RSP(%rsp)
         movq %rcx, ISTATE_OFFSET_RIP(%rsp)
@@ -396 +412 @@
  *
  */
-early_putchar:
-        
+FUNCTION_BEGIN(early_putchar)
 #if ((defined(CONFIG_EGA)) && (!defined(CONFIG_FB)))
         
@@ -525 +540 @@
         
         ret
-
+FUNCTION_END(early_putchar)