Changeset ea7890e7 in mainline for kernel/generic/src/main/uinit.c

Timestamp:

2007-06-01T15:47:46Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

07be3c4

Parents:

ff3a34b

Message:

More efficient and simpler task termination.

Based on the assumption, that after its creation, only the task itself can create more threads for itself,
the last thread with userspace context to execute thread_exit() will perform futex and IPC cleanup. When
the task has no threads, it is destroyed. Both the cleanup and destruction is controlled by reference
counting.

As for userspace threads, even though there could be a global garbage collector for joining threads, it is
much simpler if the uinit thread detaches itself before switching to userspace.

task_kill() is now an idempotent operation. It just instructs the threads within a task to exit.

Change in the name of a thread state: Undead → JoinMe.

File:

• kernel/generic/src/main/uinit.c (modified) (2 diffs)

kernel/generic/src/main/uinit.c

@@ -46 +46 @@
 #include <userspace.h>
 #include <mm/slab.h>
+#include <arch.h>
 
 /** Thread used to bring up userspace thread.
@@ -55 +56 @@
 {
         uspace_arg_t uarg;
+
+        /*
+         * So far, we don't have a use for joining userspace threads so we
+         * immediately detach each uinit thread. If joining of userspace threads
+         * is required, some userspace API based on the kernel mechanism will
+         * have to be implemented. Moreover, garbage collecting of threads that
+         * didn't detach themselves and nobody else joined them will have to be
+         * deployed for the event of forceful task termination.
+         */
+        thread_detach(THREAD);
         
         uarg.uspace_entry = ((uspace_arg_t *) arg)->uspace_entry;
         uarg.uspace_stack = ((uspace_arg_t *) arg)->uspace_stack;
         uarg.uspace_uarg = ((uspace_arg_t *) arg)->uspace_uarg;
-        uarg.uspace_thread_function = NULL;
-        uarg.uspace_thread_arg = NULL;
+        uarg.uspace_thread_function = NULL; uarg.uspace_thread_arg = NULL;
 
         free((uspace_arg_t *) arg);