Changeset eb13ef8 in mainline for uspace/srv/devman/client_conn.c

Timestamp:

2019-02-06T13:25:12Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fafb8e5

Parents:

bb97118

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-02 14:04:02)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-06 13:25:12)

Message:

Change IPC_GET_* and IPC_SET_* to accept pointer instead of lvalue

File:

• uspace/srv/devman/client_conn.c (modified) (17 diffs)

uspace/srv/devman/client_conn.c

@@ -102 +102 @@
 static void devman_fun_get_match_id(ipc_call_t *icall)
 {
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
-        size_t index = IPC_GET_ARG2(*icall);
+        devman_handle_t handle = IPC_GET_ARG1(icall);
+        size_t index = IPC_GET_ARG2(icall);
         void *buffer = NULL;
 
@@ -165 +165 @@
 static void devman_fun_get_name(ipc_call_t *icall)
 {
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
+        devman_handle_t handle = IPC_GET_ARG1(icall);
 
         fun_node_t *fun = find_fun_node(&device_tree, handle);
@@ -218 +218 @@
 static void devman_fun_get_driver_name(ipc_call_t *icall)
 {
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
+        devman_handle_t handle = IPC_GET_ARG1(icall);
 
         fun_node_t *fun = find_fun_node(&device_tree, handle);
@@ -283 +283 @@
 static void devman_fun_get_path(ipc_call_t *icall)
 {
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
+        devman_handle_t handle = IPC_GET_ARG1(icall);
 
         fun_node_t *fun = find_fun_node(&device_tree, handle);
@@ -340 +340 @@
         fibril_rwlock_read_lock(&device_tree.rwlock);
 
-        dev = find_dev_node_no_lock(&device_tree, IPC_GET_ARG1(*icall));
+        dev = find_dev_node_no_lock(&device_tree, IPC_GET_ARG1(icall));
         if (dev == NULL || dev->state == DEVICE_REMOVED) {
                 fibril_rwlock_read_unlock(&device_tree.rwlock);
@@ -374 +374 @@
 
         dev_node_t *dev = find_dev_node_no_lock(&device_tree,
-            IPC_GET_ARG1(*icall));
+            IPC_GET_ARG1(icall));
         if (dev == NULL || dev->state == DEVICE_REMOVED) {
                 fibril_rwlock_read_unlock(&device_tree.rwlock);
@@ -413 +413 @@
         fibril_rwlock_read_lock(&device_tree.rwlock);
 
-        fun = find_fun_node_no_lock(&device_tree, IPC_GET_ARG1(*icall));
+        fun = find_fun_node_no_lock(&device_tree, IPC_GET_ARG1(icall));
         if (fun == NULL || fun->state == FUN_REMOVED) {
                 fibril_rwlock_read_unlock(&device_tree.rwlock);
@@ -442 +442 @@
         errno_t rc;
 
-        fun = find_fun_node(&device_tree, IPC_GET_ARG1(*icall));
+        fun = find_fun_node(&device_tree, IPC_GET_ARG1(icall));
         if (fun == NULL) {
                 async_answer_0(icall, ENOENT);
@@ -467 +467 @@
         errno_t rc;
 
-        fun = find_fun_node(&device_tree, IPC_GET_ARG1(*icall));
+        fun = find_fun_node(&device_tree, IPC_GET_ARG1(icall));
         if (fun == NULL) {
                 async_answer_0(icall, ENOENT);
@@ -484 +484 @@
         fun_node_t *fun;
 
-        fun = find_loc_tree_function(&device_tree, IPC_GET_ARG1(*icall));
+        fun = find_loc_tree_function(&device_tree, IPC_GET_ARG1(icall));
 
         if (fun == NULL) {
@@ -550 +550 @@
         }
 
-        driver_t *drv = driver_find(&drivers_list, IPC_GET_ARG1(*icall));
+        driver_t *drv = driver_find(&drivers_list, IPC_GET_ARG1(icall));
         if (drv == NULL) {
                 async_answer_0(&call, ENOENT);
@@ -604 +604 @@
 static void devman_driver_get_match_id(ipc_call_t *icall)
 {
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
-        size_t index = IPC_GET_ARG2(*icall);
+        devman_handle_t handle = IPC_GET_ARG1(icall);
+        size_t index = IPC_GET_ARG2(icall);
 
         driver_t *drv = driver_find(&drivers_list, handle);
@@ -655 +655 @@
 static void devman_driver_get_name(ipc_call_t *icall)
 {
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
+        devman_handle_t handle = IPC_GET_ARG1(icall);
 
         driver_t *drv = driver_find(&drivers_list, handle);
@@ -697 +697 @@
         driver_t *drv;
 
-        drv = driver_find(&drivers_list, IPC_GET_ARG1(*icall));
+        drv = driver_find(&drivers_list, IPC_GET_ARG1(icall));
         if (drv == NULL) {
                 async_answer_0(icall, ENOENT);
@@ -712 +712 @@
         errno_t rc;
 
-        drv = driver_find(&drivers_list, IPC_GET_ARG1(*icall));
+        drv = driver_find(&drivers_list, IPC_GET_ARG1(icall));
         if (drv == NULL) {
                 async_answer_0(icall, ENOENT);
@@ -731 +731 @@
         errno_t rc;
 
-        drv = driver_find(&drivers_list, IPC_GET_ARG1(*icall));
+        drv = driver_find(&drivers_list, IPC_GET_ARG1(icall));
         if (drv == NULL) {
                 async_answer_0(icall, ENOENT);
@@ -754 +754 @@
                 async_get_call(&call);
 
-                if (!IPC_GET_IMETHOD(call)) {
+                if (!IPC_GET_IMETHOD(&call)) {
                         async_answer_0(&call, EOK);
                         break;
                 }
 
-                switch (IPC_GET_IMETHOD(call)) {
+                switch (IPC_GET_IMETHOD(&call)) {
                 case DEVMAN_DEVICE_GET_HANDLE:
                         devman_function_get_handle(&call);