Changes in uspace/drv/usbhub/utils.c [4c74ac3:ee0d8a8] in mainline

File:

• uspace/drv/usbhub/utils.c (modified) (15 diffs)

uspace/drv/usbhub/utils.c

@@ -34 +34 @@
  */
 #include <driver.h>
-#include <bool.h>
-#include <errno.h>
-
+#include <usb/devreq.h>
 #include <usbhc_iface.h>
 #include <usb/usbdrv.h>
 #include <usb/descriptor.h>
-#include <usb/devreq.h>
+#include <driver.h>
+#include <bool.h>
+#include <errno.h>
 #include <usb/classes/hub.h>
-
 #include "usbhub.h"
 #include "usbhub_private.h"
 #include "port_status.h"
-
+#include <usb/devreq.h>
+
+static void check_hub_changes(void);
 
 size_t USB_HUB_MAX_DESCRIPTOR_SIZE = 71;
@@ -301 +302 @@
         //result->device = device;
         result->port_count = -1;
-        /// \TODO is this correct? is the device stored?
-        result->device = device;
 
 
@@ -317 +316 @@
         }*/
 
-        result->usb_device = usb_new(usb_hcd_attached_device_info_t);
-        result->usb_device->address = addr;
+        result->device = usb_new(usb_hcd_attached_device_info_t);
+        result->device->address = addr;
 
         // get hub descriptor
@@ -363 +362 @@
 }
 
+/** Callback when new hub device is detected.
+ *
+ * @param dev New device.
+ * @return Error code.
+ */
 int usb_add_hub_device(device_t *dev) {
         printf(NAME ": add_hub_device(handle=%d)\n", (int) dev->handle);
@@ -383 +387 @@
         usb_device_request_setup_packet_t request;
         usb_target_t target;
-        target.address = hub_info->usb_device->address;
+        target.address = hub_info->device->address;
         target.endpoint = 0;
         for (port = 0; port < hub_info->port_count; ++port) {
@@ -400 +404 @@
         printf("[usb_hub] hub info added to list\n");
         //(void)hub_info;
-        usb_hub_check_hub_changes();
+        check_hub_changes();
 
         /// \TODO start the check loop, if not already started...
@@ -408 +412 @@
 
         printf("[usb_hub] hub dev added\n");
-        printf("\taddress %d, has %d ports \n",
-                        hub_info->usb_device->address,
-                        hub_info->port_count);
 
         return EOK;
@@ -428 +429 @@
  * @param target
  */
+
 static void usb_hub_init_add_device(int hc, uint16_t port, usb_target_t target) {
         usb_device_request_setup_packet_t request;
@@ -457 +459 @@
  * @param target
  */
-static void usb_hub_finalize_add_device( usb_hub_info_t * hub,
+static void usb_hub_finalize_add_device(
                 int hc, uint16_t port, usb_target_t target) {
 
@@ -477 +479 @@
                 return;
         }
-
-
         usb_drv_release_default_address(hc);
 
-        devman_handle_t child_handle;
-        opResult = usb_drv_register_child_in_devman(hc, hub->device,
-        new_device_address, &child_handle);
-        if (opResult != EOK) {
-                printf("[usb_hub] could not start driver for new device \n");
-                return;
-        }
-        usb_drv_bind_address(hc, new_device_address, child_handle);
-        
+
+        /// \TODO driver work
+        //add_child_device.....
 }
 
@@ -525 +519 @@
  * @param target
  */
-static void usb_hub_process_interrupt(usb_hub_info_t * hub, int hc, uint16_t port, usb_target_t target) {
+static void usb_hub_process_interrupt(int hc, uint16_t port, usb_target_t target) {
         printf("[usb_hub] interrupt at port %d\n", port);
         //determine type of change
@@ -560 +554 @@
                 printf("[usb_hub] finalizing add device\n");
                 if (usb_port_enabled(&status)) {
-                        usb_hub_finalize_add_device(hub, hc, port, target);
+                        usb_hub_finalize_add_device(hc, port, target);
                 } else {
                         printf("[usb_hub] ERROR: port reset, but port still not enabled\n");
@@ -591 +585 @@
 /** Check changes on all known hubs.
  */
-void usb_hub_check_hub_changes(void) {
+static void check_hub_changes(void) {
         /*
          * Iterate through all hubs.
@@ -600 +594 @@
                         lst_item = lst_item->next) {
                 printf("[usb_hub] checking hub changes\n");
-                usb_hub_info_t * hub_info = ((usb_hub_info_t*)lst_item->data);
                 /*
                  * Check status change pipe of this hub.
                  */
 
-                usb_target_t target;
-                target.address = hub_info->usb_device->address;
-                target.endpoint = 1;
-
-                size_t port_count = hub_info->port_count;
+                usb_target_t target = {
+                        .address = 5,
+                        .endpoint = 1
+                };
+                /// \TODO uncomment once it works correctly
+                //target.address = usb_create_hub_info(lst_item)->device->address;
+
+                size_t port_count = 7;
 
                 /*
                  * Connect to respective HC.
                  */
-                int hc = usb_drv_hc_connect(hub_info->device, 0);
+                /// \FIXME this is incorrect code: here
+                /// must be used particular device instead of NULL
+                //which one?
+                int hc = usb_drv_hc_connect(NULL, 0);
                 if (hc < 0) {
                         continue;
@@ -643 +642 @@
                         bool interrupt = (((uint8_t*) change_bitmap)[port / 8] >> (port % 8)) % 2;
                         if (interrupt) {
-                                usb_hub_process_interrupt(hub_info, hc, port, target);
+                                usb_hub_process_interrupt(hc, port, target);
                         }
                 }