Changeset f1938c6 in mainline for uspace/lib/c/generic/net/icmp_common.c

Timestamp:

2011-01-17T15:41:30Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a2d8d59, ffaba00

Parents:

9f3864a

Message:

streamline ICMP implementation

• generate ICMP identification based on fibril counter
• use fibril-local ICMP sequence numbers
• use hash table (instead of char map) for ICMP replies
• simplify locking
• simplify ICMP communication

File:

• uspace/lib/c/generic/net/icmp_common.c (modified) (2 diffs)

uspace/lib/c/generic/net/icmp_common.c

@@ -27 +27 @@
  */
 
-/** @addtogroup libc 
+/** @addtogroup libc
  *  @{
  */
@@ -38 +38 @@
 #include <net/modules.h>
 #include <net/icmp_common.h>
-
 #include <ipc/services.h>
 #include <ipc/icmp.h>
-
 #include <sys/time.h>
 #include <async.h>
 
-/** Connects to the ICMP module.
+/** Connect to the ICMP module.
  *
- * @param service       The ICMP module service. Ignored parameter.
- * @param[in] timeout   The connection timeout in microseconds. No timeout if
- *                      set to zero.
- * @return              The ICMP module phone on success.
- * @return              ETIMEOUT if the connection timeouted.
+ * @param[in] timeout Connection timeout in microseconds, zero
+ *                    for no timeout.
+ *
+ * @return ICMP module phone on success.
+ * @return ETIMEOUT if the connection timeouted.
+ *
  */
-int icmp_connect_module(services_t service, suseconds_t timeout)
+int icmp_connect_module(suseconds_t timeout)
 {
-        int phone;
-
-        phone = connect_to_service_timeout(SERVICE_ICMP, timeout);
-        if (phone >= 0)
-                async_req_0_0(phone, NET_ICMP_INIT);
-
-        return phone;
+        return connect_to_service_timeout(SERVICE_ICMP, timeout);
 }