Changeset f215bb5 in mainline

Timestamp:

2011-07-27T21:24:32Z (13 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fd4b636

Parents:

77c6698

Message:

Various little changes.

Location:

uspace/lib/posix

Files:

• ctype.c (modified) (1 diff)
• fnmatch.c (modified) (2 diffs)
• pwd.c (modified) (7 diffs)
• pwd.h (modified) (1 diff)
• signal.c (modified) (2 diffs)

uspace/lib/posix/ctype.c

@@ -94 +94 @@
 int posix_isprint(int c)
 {
-        return posix_isacsii(c) && !posix_iscntrl(c);
+        return posix_isascii(c) && !posix_iscntrl(c);
 }
 

uspace/lib/posix/fnmatch.c

@@ -525 +525 @@
 static char *_casefold(const char *s)
 {
+        assert(s != NULL);
         char *result = strdup(s);
         for (char *i = result; *i != '\0'; ++i) {
@@ -542 +543 @@
 int posix_fnmatch(const char *pattern, const char *string, int flags)
 {
+        assert(pattern != NULL);
+        assert(string != NULL);
+
         // TODO: don't fold everything in advance, but only when needed
 

uspace/lib/posix/pwd.c

@@ -39 +39 @@
 #include "errno.h"
 
-// TODO: documentation
-
 static bool entry_read = false;
 
@@ -46 +44 @@
 static const struct posix_passwd dummy_pwd = {
         .pw_name = (char *) "user",
-        .pw_uid = 1,
-        .pw_gid = 1,
+        .pw_uid = 0,
+        .pw_gid = 0,
         .pw_dir = (char *) "/",
         .pw_shell = (char *) "/app/bdsh"
@@ -115 +113 @@
 {
         assert(name != NULL);
+        assert(pwd != NULL);
+        assert(buffer != NULL);
+        assert(result != NULL);
         
         if (posix_strcmp(name, "user") != 0) {
@@ -121 +122 @@
         }
         
-        return posix_getpwuid_r(1, pwd, buffer, bufsize, result);
+        return posix_getpwuid_r(0, pwd, buffer, bufsize, result);
 }
 
@@ -132 +133 @@
 struct posix_passwd *posix_getpwuid(posix_uid_t uid)
 {
-        if (uid != 1) {
+        if (uid != 0) {
                 return NULL;
         }
@@ -159 +160 @@
             '/', '\0', 'b', 'd', 's', 'h', '\0' };
         
-        if (uid != 1) {
+        if (uid != 0) {
                 *result = NULL;
                 return 0;
@@ -171 +172 @@
 
         pwd->pw_name = (char *) bf;
-        pwd->pw_uid = 1;
-        pwd->pw_gid = 1;
+        pwd->pw_uid = 0;
+        pwd->pw_gid = 0;
         pwd->pw_dir = (char *) bf + 5;
         pwd->pw_shell = (char *) bf + 7;

uspace/lib/posix/pwd.h

@@ -35 +35 @@
 #ifndef POSIX_PWD_H_
 #define POSIX_PWD_H_
-
-// TODO: documentation
 
 #include "sys/types.h"

uspace/lib/posix/signal.c

@@ -66 +66 @@
 
 /**
- * 
- * @param signo
+ * Default signal handler. Executes the default action for each signal,
+ * as reasonable within HelenOS.
+ *
+ * @param signo Signal number.
  */
 void __posix_default_signal_handler(int signo)
@@ -75 +77 @@
                 abort();
         case SIGQUIT:
-                fprintf(stderr, "Quit signal raised. Exiting.");
+                fprintf(stderr, "Quit signal raised. Exiting.\n");
                 exit(EXIT_FAILURE);
         case SIGINT:
-                fprintf(stderr, "Interrupt signal caught. Exiting.");
+                fprintf(stderr, "Interrupt signal caught. Exiting.\n");
                 exit(EXIT_FAILURE);
         case SIGTERM:
-                fprintf(stderr, "Termination signal caught. Exiting.");
+                fprintf(stderr, "Termination signal caught. Exiting.\n");
                 exit(EXIT_FAILURE);
         case SIGSTOP:
-                fprintf(stderr, "Stop signal caught, but unsupported. Ignoring.");
+                fprintf(stderr, "Stop signal caught, but unsupported. Ignoring.\n");
                 break;
         case SIGKILL: