Changeset f959a20f in mainline for uspace/drv/bus/usb/uhci/transfer_list.c

Timestamp:

2019-02-01T22:32:38Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

00b7fc8

Parents:

1a37496

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-01 21:22:39)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-01 22:32:38)

Message:

Avoid directly using .head/.next/.prev of list_t/link_t

Use existing constructs from <adt/list.h> instead.

File:

• uspace/drv/bus/usb/uhci/transfer_list.c (modified) (1 diff)

uspace/drv/bus/usb/uhci/transfer_list.c

@@ -233 +233 @@
         const char *qpos = "FIRST";
         qh_t *prev_qh = instance->queue_head;
+        link_t *prev = list_prev(&uhci_batch->link, &instance->batch_list);
         /* Remove from the hardware queue */
-        if (list_first(&instance->batch_list) != &uhci_batch->link) {
+        if (prev) {
                 /* There is a batch in front of me */
-                prev_qh =
-                    uhci_transfer_batch_from_link(uhci_batch->link.prev)->qh;
+                prev_qh = uhci_transfer_batch_from_link(prev)->qh;
                 qpos = "NOT FIRST";
         }