Changes in uspace/drv/uhci-rhd/port.c [f9c03b5:fbefd0e] in mainline

File:

• uspace/drv/uhci-rhd/port.c (modified) (5 diffs)

uspace/drv/uhci-rhd/port.c

@@ -43 +43 @@
 #include "port.h"
 
-static int uhci_port_check(void *port);
-static int uhci_port_reset_enable(int portno, void *arg);
 static int uhci_port_new_device(uhci_port_t *port, usb_speed_t speed);
 static int uhci_port_remove_device(uhci_port_t *port);
 static int uhci_port_set_enabled(uhci_port_t *port, bool enabled);
+static int uhci_port_check(void *port);
+static int uhci_port_reset_enable(int portno, void *arg);
 static void uhci_port_print_status(
     uhci_port_t *port, const port_status_t value);
@@ -74 +74 @@
         pio_write_16(port->address, value);
 }
+
 /*----------------------------------------------------------------------------*/
 /** Initialize UHCI root hub port instance.
@@ -258 +259 @@
 
         usb_address_t dev_addr;
-        int ret = usb_hc_new_device_wrapper(port->rh, &port->hc_connection,
+        int rc = usb_hc_new_device_wrapper(port->rh, &port->hc_connection,
             speed, uhci_port_reset_enable, port->number, port,
             &dev_addr, &port->attached_device, NULL, NULL, NULL);
 
-        if (ret != EOK) {
+        if (rc != EOK) {
                 usb_log_error("%s: Failed(%d) to add device: %s.\n",
-                    port->id_string, ret, str_error(ret));
+                    port->id_string, rc, str_error(rc));
                 uhci_port_set_enabled(port, false);
-                return ret;
+                return rc;
         }
 
@@ -286 +287 @@
 int uhci_port_remove_device(uhci_port_t *port)
 {
-        usb_log_error("%s: Don't know how to remove device %llu.\n",
-            port->id_string, port->attached_device);
-        return ENOTSUP;
+        usb_log_error("%s: Don't know how to remove device %d.\n",
+            port->id_string, (unsigned int)port->attached_device);
+        return EOK;
 }
 /*----------------------------------------------------------------------------*/
@@ -340 +341 @@
             (value & STATUS_CONNECTED_CHANGED) ? " CONNECTED-CHANGE," : "",
             (value & STATUS_CONNECTED) ? " CONNECTED," : "",
-            (value & STATUS_ALWAYS_ONE) ? " ALWAYS ONE" : " ERR: NO ALWAYS ONE"
+            (value & STATUS_ALWAYS_ONE) ? " ALWAYS ONE" : " ERROR: NO ALWAYS ONE"
         );
 }