Changeset fc4abca in mainline

Timestamp:

2020-07-04T22:32:04Z (4 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d74a2b8, e37378be

Parents:

fd11144

Message:

IPC GC server needs to destroy all lingering bitmaps

The client could exit without destroying all bitmaps in case it is
misbehaving or if it crashed.

File:

• uspace/lib/ipcgfx/src/server.c (modified) (2 diffs)

uspace/lib/ipcgfx/src/server.c

@@ -331 +331 @@
 {
         ipc_gc_srv_t srvgc;
+        ipc_gc_srv_bitmap_t *bitmap;
+        link_t *link;
 
         /* Accept the connection */
@@ -375 +377 @@
         }
 
-        // TODO: Destroy all remaining bitmaps (+ emit warning?)
+        /*
+         * Destroy all remaining bitmaps. A client should destroy all
+         * the bitmaps before closing connection. But it could happen
+         * that the client is misbehaving or was abruptly disconnected
+         * (e.g. crashed).
+         */
+        link = list_first(&srvgc.bitmaps);
+        while (link != NULL) {
+                bitmap = list_get_instance(link, ipc_gc_srv_bitmap_t,
+                    lbitmaps);
+
+                (void) gfx_bitmap_destroy(bitmap->bmp);
+                if (bitmap->myalloc)
+                        as_area_destroy(bitmap->pixels);
+                list_remove(&bitmap->lbitmaps);
+                free(bitmap);
+
+                link = list_first(&srvgc.bitmaps);
+        }
+
         return EOK;
 }