Changes in uspace/srv/fs/fat/fat_ops.c [f73b291:feeac0d] in mainline

File:

• uspace/srv/fs/fat/fat_ops.c (modified) (5 diffs)

uspace/srv/fs/fat/fat_ops.c

@@ -149 +149 @@
 static int fat_node_fini_by_service_id(service_id_t service_id)
 {
-        fat_node_t *nodep;
         int rc;
 
@@ -160 +159 @@
 restart:
         fibril_mutex_lock(&ffn_mutex);
-        list_foreach(ffn_list, lnk) {
-                nodep = list_get_instance(lnk, fat_node_t, ffn_link);
+        list_foreach(ffn_list, ffn_link, fat_node_t, nodep) {
                 if (!fibril_mutex_trylock(&nodep->lock)) {
                         fibril_mutex_unlock(&ffn_mutex);
@@ -651 +649 @@
                 d = (fat_dentry_t *) b->data;
                 if ((fat_classify_dentry(d) == FAT_DENTRY_LAST) ||
-                    (bcmp(d->name, FAT_NAME_DOT, FAT_NAME_LEN)) == 0) {
+                    (memcmp(d->name, FAT_NAME_DOT, FAT_NAME_LEN)) == 0) {
                         memset(d, 0, sizeof(fat_dentry_t));
                         memcpy(d->name, FAT_NAME_DOT, FAT_NAME_LEN);
@@ -661 +659 @@
                 d++;
                 if ((fat_classify_dentry(d) == FAT_DENTRY_LAST) ||
-                    (bcmp(d->name, FAT_NAME_DOT_DOT, FAT_NAME_LEN) == 0)) {
+                    (memcmp(d->name, FAT_NAME_DOT_DOT, FAT_NAME_LEN) == 0)) {
                         memset(d, 0, sizeof(fat_dentry_t));
                         memcpy(d->name, FAT_NAME_DOT_DOT, FAT_NAME_LEN);
@@ -1042 +1040 @@
         info = (fat32_fsinfo_t *) b->data;
 
-        if (bcmp(info->sig1, FAT32_FSINFO_SIG1, sizeof(info->sig1)) ||
-            bcmp(info->sig2, FAT32_FSINFO_SIG2, sizeof(info->sig2)) ||
-            bcmp(info->sig3, FAT32_FSINFO_SIG3, sizeof(info->sig3))) {
+        if (memcmp(info->sig1, FAT32_FSINFO_SIG1, sizeof(info->sig1)) != 0 ||
+            memcmp(info->sig2, FAT32_FSINFO_SIG2, sizeof(info->sig2)) != 0 ||
+            memcmp(info->sig3, FAT32_FSINFO_SIG3, sizeof(info->sig3)) != 0) {
                 (void) block_put(b);
                 return EINVAL;