Timeline



2019-11-22:

23:27 Ticket #752 (hound crashes on a dual-CPU system) updated by Jiri Svoboda
Not 100% sure if it's the same thing, but you can reproduce this when …

2019-11-21:

16:24 Changeset in mainline [670cfcf]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Optimize terminal rendering This is pretty much equivalent of what …
13:45 Changeset in mainline [8b1ce56]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Computing rectangle envelope Useful for tracking changed areas, for …

2019-11-20:

08:00 Ticket #813 (Incremental build does not detect changes to uspace/overlay) closed by Vojtech Horky
fixed: Yes, that fixed it (build 407 improved a lot), closing. Thanks!

2019-11-19:

18:03 Ticket #813 (Incremental build does not detect changes to uspace/overlay) updated by Jiří Zárevúcky
Commit …
18:00 Changeset in mainline [c6ac9a55]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by GitHub <noreply@…>
meson: Always rebuild filesystem image Tells meson to rebuild …
09:31 Ticket #813 (Incremental build does not detect changes to uspace/overlay) updated by Jiri Svoboda
I think this might be the cause of CI tests failing .. they don't find …
09:21 Changeset in mainline [bf22cb78]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix 32-bit build
09:20 Changeset in mainline [959ef5d]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Change wording
09:06 Changeset in mainline [48f7e47]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Port terminal application directly to display service This is …

2019-11-17:

23:30 Changeset in mainline [32dde7e8]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Handle errors correctly
23:19 Changeset in mainline [ecb7828]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Export libgfx, libipcgfx, libdisplay

2019-11-16:

23:42 Changeset in mainline [34e91bf] by Matthieu Riolo <matthieu.riolo@…>
Deleting taskman_noasync Since IPC and async should be mixed, it …

2019-11-15:

18:45 Changeset in mainline [ae004bc] by Matthieu Riolo <matthieu.riolo@…>
correcting create_session() calls When creating a new session for a …
18:32 Ticket #811 (PCUT should not prefix test case identifiers with "test_") updated by Jiri Svoboda
It happened to me several times so it's not unlikely. The fact that …
13:46 Changeset in mainline [84876aa4]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Merge master into gfx Mainly to get XCW fixes
12:18 Ticket #813 (Incremental build does not detect changes to uspace/overlay) created by Jiri Svoboda
When I change contents of uspace/overlay (e.g. make install in …
11:52 Changeset in mainline [d548fc0]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Bring back helenos-bld-config and ammend XCW demo Demonstrate use of …
10:27 Changeset in mainline [b78300f]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Also fix helenos-pkg-config
10:05 Changeset in mainline [fc65b87]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix missing libraries for gzx, msim, sycek It seems the export …
10:03 Changeset in mainline [1b9a853]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix XCW both manual case and when ran by HSCT

2019-11-13:

13:14 Changeset in mainline [e1abc964]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Move UDP's client association to a separate module
10:45 ReleaseNotes/Mainline edited by Jiri Svoboda
alias, trace, UDP unit tests, French keyboard layout (diff)

2019-11-12:

12:07 Ticket #811 (PCUT should not prefix test case identifiers with "test_") updated by Jiří Zárevúcky
I don't see why that matters. Test case names are decorative only and …
09:55 Ticket #812 (XCW is broken) created by Jiri Svoboda
The switch to meson build system broke XCW. I tried: * manually …

2019-11-11:

13:04 Changeset in mainline [b093a62]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix event delivery test There was an infinite supply of events which …

2019-11-10:

17:07 Changeset in mainline [da412547]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Display server should deal with client not destroying windows properly
16:51 Changeset in mainline [6427f083]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Do not forget to end exchange in failure case of display_get_event()
16:36 Changeset in mainline [dcac756]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Improve libdisplay tests, fix bugs

2019-11-09:

22:01 Ticket #811 (PCUT should not prefix test case identifiers with "test_") created by Jiri Svoboda
Declaring something like […] fails to compile because foo
19:06 Changeset in mainline [453c5ce]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jakub Jermář <jakub@…>
Added support for French keyboard layout Use CTRL+F5 to use it.
17:16 Changeset in mainline [38e4f42]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Add tests for libipcgfx
12:55 Changeset in mainline [a412d59f] by CHTCHEGLOV Ilia <chtcheglov.ilia@…>
Added support for French keyboard layout Use CTRL+F5 to use it.

2019-11-08:

08:58 Changeset in mainline [bac129a]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Remove forgotten comment
08:52 Changeset in mainline [bfddc62]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Finish libdisplay tests

2019-11-06:

21:10 Changeset in mainline [e422ff6]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
ds_client_get_event() should not block if no events are pending This …
18:10 Changeset in mainline [959b7ec]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Start adding tests for libdisplay and fix display_close So far we …
13:23 Changeset in mainline [648e2ac]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
ds_window_delete should be ds_window_destroy
13:20 Changeset in mainline [b2d1df3]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix test, add missing tests for ds_client and ds_display

2019-11-05:

08:00 Changeset in mainline [be15256]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
ds_client should not have reverse dependency on libdisplay's …

2019-11-04:

14:05 Changeset in mainline [b3c185b6]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Window event delivery mechanism

2019-10-29:

02:34 Changeset in mainline [22faaf2]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
A little bit of tiling support
02:01 Changeset in mainline [587b4cb]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Clear screen between demos, add second bitmap demo

2019-10-26:

23:30 Changeset in mainline [0008c0f]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Bitmaps in IPC GC and in display server

2019-10-23:

17:50 Changeset in mainline [e18f0c0]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiří Zárevúcky <zarevucky.jiri@…>
Run doxygen in the correct directory

2019-10-21:

18:23 Changeset in mainline [7b882c1f]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Need some vector operations
00:17 Changeset in mainline [1822545]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Add typedef for scalar coordinate Because today I feel like adding it
00:08 Changeset in mainline [d18f3b7]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Implement bitmaps in console GC

2019-10-19:

10:07 Changeset in mainline [e0545de]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Implement bitmaps in canvas GC, demo in gfxdemo

2019-10-17:

23:20 Changeset in mainline [dcc4cb31]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Refine bitmap ops and add tests

2019-10-15:

16:33 Changeset in mainline [78a71936]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Bitmap operations (WIP)
12:03 Changeset in mainline [924fd60]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Remove forgotten debug variables
09:52 Changeset in mainline [46a8c3cd]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Add unit tests for UDP servers' msg and pdu modules

2019-10-14:

15:30 Changeset in mainline [fc0de8c]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jakub Jermar <jakub@…>
Move kobject's ops out of kobject Kobject ops is a property of the …
11:23 Changeset in mainline [f1cd4b0]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix indentation
11:16 Changeset in mainline [89ba88c]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Test udp_assoc_send() This required virtualizing inet_get_src_addr() …
07:32 Changeset in mainline [25525133]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
UDP association tests for addref, delref, set_iplink, received, reset

2019-10-12:

00:22 Changeset in mainline [16b0ac3]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Start adding unit tests for UDP associations

2019-10-11:

23:41 CodingTips edited by Jiri Svoboda
(diff)
23:37 WikiStart edited by Jiri Svoboda
(diff)
23:31 HowToContribute edited by Jiri Svoboda
Long-running tasks (diff)

2019-10-10:

10:17 Changeset in mainline [159776f]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Provisional display server output via canvas/guigfx

2019-10-09:

01:23 Ticket #807 (libc failing unit tests) closed by Jiri Svoboda
fixed: Fixed * capa_format_rounding in changeset …

2019-10-08:

12:15 Changeset in mainline [a163d10]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix getopt_optional_param test failing This is a bug in the test, …
12:04 Changeset in mainline [de65624]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix too many integer digits when rounding capacity up Apparently, …
11:24 Ticket #804 (Tracing a task causes it to crash) updated by Jiri Svoboda
Milestone changed
11:23 Ticket #804 (Tracing a task causes it to crash) closed by Jiri Svoboda
fixed: Fixed in changeset …
10:23 Ticket #32 (ppc32: use proper permissions on pages) updated by Jiri Svoboda
Type changed
This is an enhancement, really.
10:21 Ticket #801 (test-srv_net_tcp: tqueue tests crash) closed by Jiri Svoboda
fixed: Fixed in changeset …
00:31 Changeset in mainline [cf9a1e2]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Fix use of unitialized variable Found by gcc -Og
00:30 Changeset in mainline [3106054]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Do not use segment after freeing in TCP server's tqueue tests
00:24 Ticket #801 (test-srv_net_tcp: tqueue tests crash) updated by Jiri Svoboda
This is a bug in the tests. tqueue_test_transmit_seg records a …

2019-10-07:

12:41 Ticket #802 (test-srv_volsrv: volume/same_twice test hits an assertion) closed by Jiri Svoboda
fixed: Solved in …
11:21 Changeset in mainline [0a201454]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Volsrv should not use zero as a valid reference count Volume server …
11:12 Ticket #802 (test-srv_volsrv: volume/same_twice test hits an assertion) updated by Jiri Svoboda
In the same_twice test we lookup-ref a volume, then delete the …

2019-10-06:

19:47 Changeset in mainline [7ffdcbd] by Matthieu Riolo <matthieu.riolo@…>
Correcting IPC calls introduced with taskman The new PHONE_INITIAL …
19:47 Changeset in mainline [5be6361] by Matthieu Riolo <matthieu.riolo@…>
Make use of helper function in lib/taskman The code provided helper …
19:47 Changeset in mainline [03daabd] by Matthieu Riolo <matthieu.riolo@…>
Renaming dyn_array to array The term dyn_array is redunant and has …
19:47 Changeset in mainline [9559cf8] by Matthieu Riolo <matthieu.riolo@…>
Relocate dyn_array test into the correct subfolder
19:47 Changeset in mainline [25697163] by Matthieu Riolo <matthieu.riolo@…>
Replacing int with errno_t The merged code from system-daemon still …

2019-10-05:

16:26 Ticket #809 (Volume server failing unit test) closed by Jakub Jermář
duplicate
16:26 Ticket #808 (tcp server failing unit tests) closed by Jakub Jermář
duplicate
12:59 Ticket #810 (Run all unit tests as part of CI) created by Jiri Svoboda
We have a slowly, but steadily growing collection of PCUT-based unit …
10:00 Ticket #808 (tcp server failing unit tests) updated by Jakub Jermář
Keywords changed
This is a duplicate of #801.
09:59 Ticket #809 (Volume server failing unit test) updated by Jakub Jermář
See also changed
This is a duplicate of #802.
09:32 Ticket #809 (Volume server failing unit test) created by Jiri Svoboda
As of revision …
09:30 Ticket #807 (libc failing unit tests) updated by Jiri Svoboda
Component, Owner changed
09:29 Ticket #808 (tcp server failing unit tests) created by Jiri Svoboda
As of revision …
09:26 Ticket #807 (libc failing unit tests) created by Jiri Svoboda
As of revision …
09:19 Changeset in mainline [bef51cf]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Need a few more tests for ds_display_t/ds_window_t
08:45 Changeset in mainline [6af4b4f]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Introduce ds_display_t, ds_window_t

2019-10-03:

09:10 Changeset in mainline [c8cf261]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Display server scaffolding

2019-10-02:

16:09 Ticket #805 (Debug session not cleaned up if debugger gets killed) updated by Jakub Jermář
This should not be the case of ipc_phone_hangup as there we don't …
14:28 Ticket #806 (Trace/command freezes for some commands) updated by Jakub Jermář
Keywords changed
14:27 Ticket #805 (Debug session not cleaned up if debugger gets killed) updated by Jakub Jermář
Keywords changed
14:25 Ticket #804 (Tracing a task causes it to crash) updated by Jakub Jermář
Keywords changed
14:22 Ticket #804 (Tracing a task causes it to crash) updated by Jiri Svoboda
Component changed
14:21 Ticket #806 (Trace/command freezes for some commands) created by Jiri Svoboda
When I run trace +s <command> for some commands like …
13:36 Ticket #805 (Debug session not cleaned up if debugger gets killed) updated by Jiri Svoboda
Any ideas how to approach this? It seems to me maybe sender is NULL on …
13:36 Ticket #805 (Debug session not cleaned up if debugger gets killed) created by Jiri Svoboda
Any number of tasks might have a phone Pn open to a target task T's …
12:36 Changeset in mainline [5667dca]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Do not block faulted task until debugger exits If a task faults while …
10:27 Changeset in mainline [9dcf472]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Trace should not wait for spawned task by ID It can just use a …
09:27 Changeset in mainline [2443ad8]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Let trace not use the loader API directly This fixes traced binaries …

2019-10-01:

09:03 Changeset in mainline [6fa3a03]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Improve the chances of trace's syscall table remaining up to date
08:56 Ticket #804 (Tracing a task causes it to crash) updated by Jiri Svoboda
The root cause: {/app/trace} does not use task_spawnxxx to …
08:47 Ticket #804 (Tracing a task causes it to crash) updated by Jiri Svoboda
I suspected the problem could be arch-specific, but confirmed this, …
08:13 Ticket #804 (Tracing a task causes it to crash) updated by Jiri Svoboda
An example with /app/tester (disabled shared libraries): […] The …

2019-09-30:

18:01 Changeset in mainline [8f57fb2]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jakub Jermar <jakub@…>
Fix header guard
16:38 Changeset in mainline [c24b0dcb]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jakub Jermar <jakub@…>
Rename capacity-related 'cap' to 'capa' This allows to use 'cap' for …
14:44 Ticket #804 (Tracing a task causes it to crash) updated by Jiri Svoboda
If I kill taskmon beforehand, the task still faults, but …
13:39 Ticket #804 (Tracing a task causes it to crash) created by Jiri Svoboda
Running /app/trace +s <command> causes that command to crash …
13:33 Changeset in mainline [ef0a3375]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Update syscall table in syscall tracer Overdue by waaay too long!

2019-09-29:

13:58 Changeset in mainline [0a2c96c]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jakub Jermar <jakub@…>
Check for unsigned wrap-around in malloc
12:58 Ticket #803 (ninja doxygen fails) created by Jakub Jermář
When trying to build the doxygen documentation, I get the following …
12:53 Ticket #802 (test-srv_volsrv: volume/same_twice test hits an assertion) created by Jakub Jermář
When running the *same_twice* test from the *volume* suite from test- …
11:56 Ticket #801 (test-srv_net_tcp: tqueue tests crash) updated by Jakub Jermář
Summary, Description changed
11:50 Ticket #801 (test-srv_net_tcp: tqueue tests crash) created by Jakub Jermář
When running the *ctrl_seg_teardown*, *test_new_data_fin* or …

2019-09-25:

10:52 Changeset in mainline [aac5069]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Add IPC transport library for GFX

2019-09-24:

11:13 Changeset in mainline [a3f63ac]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Move canvas GC and console GC out of libgfx We need libgfx not to …

2019-09-23:

15:09 UsersGuide/QuickStart edited by Martin Decky
update the ISO URL and QEMU command line (diff)
14:24 Changeset in mainline [00e8290]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Canvas backend for libgfx
13:05 Changeset in mainline [9be2358]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Caller needs entire console GC to be able to destroy it properly
12:49 Changeset in mainline [3e828ea]lfnserialticket/834-toolchain-updatetopic/msim-upgradetopic/simplify-dev-export by Jiri Svoboda <jiri@…>
Merge changes from master, especially Meson build

2019-09-02:

19:01 Changeset in mainline [102f641] by Matthieu Riolo <matthieu.riolo@…>
Correcting syntax according to ccheck
18:41 Ticket #800 (aarch64 boot crashes without explanation when init files are uncompressed) updated by Petr Pavlu
Status, Owner changed

2019-08-31:

10:45 Changeset in mainline [241f1985] by Matthieu Riolo <matthieu.riolo@…>
Correcting failure from previous merge The commits from Michal Koutný …

2019-08-30:

15:37 Ticket #800 (aarch64 boot crashes without explanation when init files are uncompressed) updated by Jakub Jermář
Component changed
15:33 Ticket #800 (aarch64 boot crashes without explanation when init files are uncompressed) updated by Jakub Jermář
Cc changed

2019-08-25:

11:21 ReleaseNotes/Mainline edited by Jakub Jermář
(diff)
11:19 ReleaseNotes/Mainline edited by Jakub Jermář
(diff)
Note: See TracTimeline for information about the timeline view.