Changeset 60744cb in mainline for uspace/drv/nic/rtl8169/driver.c

Timestamp:

2024-05-17T17:51:56Z (7 weeks ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master

Children:

1801005

Parents:

646849b3

Message:

Let driver specify any argument to IRQ handler

This allows the driver to register a single handler for multiple
interrupts and still distinguish between them. It also removes
the extra step of having to get softstate from ddf_dev_t.

File:

• uspace/drv/nic/rtl8169/driver.c (modified) (6 diffs)

uspace/drv/nic/rtl8169/driver.c

@@ -74 +74 @@
 static errno_t rtl8169_on_stopped(nic_t *nic_data);
 static void rtl8169_send_frame(nic_t *nic_data, void *data, size_t size);
-static void rtl8169_irq_handler(ipc_call_t *icall, ddf_dev_t *dev);
+static void rtl8169_irq_handler(ipc_call_t *icall, void *);
 static inline errno_t rtl8169_register_int_handler(nic_t *nic_data,
     cap_irq_handle_t *handle);
@@ -372 +372 @@
         rtl8169_irq_code.cmds[3].addr = rtl8169->regs + IMR;
         errno_t rc = register_interrupt_handler(nic_get_ddf_dev(nic_data),
-            rtl8169->irq, rtl8169_irq_handler, &rtl8169_irq_code, handle);
+            rtl8169->irq, rtl8169_irq_handler, (void *)rtl8169,
+            &rtl8169_irq_code, handle);
 
         return rc;
@@ -1033 +1034 @@
 }
 
-static void rtl8169_irq_handler(ipc_call_t *icall, ddf_dev_t *dev)
-{
-        assert(dev);
-        assert(icall);
-
+/** RTL8169 IRQ handler.
+ *
+ * @param icall IRQ event notification
+ * @param arg Argument (rtl8169_t *)
+ */
+static void rtl8169_irq_handler(ipc_call_t *icall, void *arg)
+{
         uint16_t isr = (uint16_t) ipc_get_arg2(icall) & INT_KNOWN;
-        nic_t *nic_data = nic_get_from_ddf_dev(dev);
-        rtl8169_t *rtl8169 = nic_get_specific(nic_data);
+        rtl8169_t *rtl8169 = (rtl8169_t *)arg;
 
         ddf_msg(LVL_DEBUG, "rtl8169_irq_handler(): isr=0x%04x", isr);
@@ -1050 +1052 @@
                 /* Packet underrun or link change */
                 if (isr & INT_PUN) {
-                        rtl8169_link_change(dev);
+                        rtl8169_link_change(rtl8169->dev);
                         pio_write_16(rtl8169->regs + ISR, INT_PUN);
                 }
@@ -1056 +1058 @@
                 /* Transmit notification */
                 if (isr & (INT_TER | INT_TOK | INT_TDU)) {
-                        rtl8169_transmit_done(dev);
+                        rtl8169_transmit_done(rtl8169->dev);
                         pio_write_16(rtl8169->regs + ISR, (INT_TER | INT_TOK | INT_TDU));
                 }
@@ -1072 +1074 @@
 
                 if (isr & (INT_RER | INT_ROK)) {
-                        rtl8169_receive_done(dev);
+                        rtl8169_receive_done(rtl8169->dev);
                         pio_write_16(rtl8169->regs + ISR, (INT_RER | INT_ROK));
                 }