Changeset a35b458 in mainline for kernel/arch/amd64/src/smp/ap.S

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• kernel/arch/amd64/src/smp/ap.S (modified) (4 diffs)

kernel/arch/amd64/src/smp/ap.S

@@ -55 +55 @@
         xorw %ax, %ax
         movw %ax, %ds
-        
+
         lgdtl ap_gdtr       # initialize Global Descriptor Table register
-        
+
         movl %cr0, %eax
         orl $CR0_PE, %eax
@@ -71 +71 @@
         movw $GDT_SELECTOR(UDATA_DES), %ax
         movw %ax, %gs
-        
+
         # Enable 64-bit page transaltion entries (CR4.PAE = 1).
         # Paging is not enabled until after long mode is enabled
-        
+
         movl %cr4, %eax
         orl $CR4_PAE, %eax
         movl %eax, %cr4
-        
+
         leal ptl_0, %eax
         movl %eax, %cr3
-        
+
         # Enable long mode
         movl $AMD_MSR_EFER, %ecx  # EFER MSR number
@@ -87 +87 @@
         orl $AMD_LME, %eax        # Set LME=1
         wrmsr                     # Write EFER
-        
+
         # Enable paging to activate long mode (set CR0.PG = 1)
         movl %cr0, %eax
         orl $CR0_PG, %eax
         movl %eax, %cr0
-        
+
         # At this point we are in compatibility mode
         jmpl $GDT_SELECTOR(KTEXT_DES), $start64 - BOOT_OFFSET + AP_BOOT_OFFSET
@@ -100 +100 @@
         movabsq $ctx, %rsp
         movq CONTEXT_OFFSET_SP(%rsp), %rsp
-        
+
         pushq $0
         movq %rsp, %rbp
-        
+
         movabsq $main_ap, %rax
         callq *%rax   # never returns