Changeset 0b47781 in mainline for kernel/generic/include/synch/condvar.h

Timestamp:

2025-04-10T17:23:30Z (5 days ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

c626117

Parents:

a78b0a0

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-10 16:29:50)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-10 17:23:30)

Message:

Extend kernel condvar_t to work with spinlocks

MUTEX_ACTIVE is a poor copy of the spinlock, made solely to allow
using condvars with it. Solve that issue the other way around,
by making condvar_wait() generic, so that we can get rid of that
hack.

File:

• kernel/generic/include/synch/condvar.h (modified) (2 diffs)

kernel/generic/include/synch/condvar.h

@@ -1 +1 @@
 /*
  * Copyright (c) 2001-2004 Jakub Jermar
+ * Copyright (c) 2025 Jiří Zárevúcky
  * All rights reserved.
  *
@@ -53 +54 @@
         condvar_t name = CONDVAR_INITIALIZER(name)
 
-#ifdef CONFIG_SMP
-#define _condvar_wait_timeout_spinlock(cv, lock, usec, flags) \
-        _condvar_wait_timeout_spinlock_impl((cv), (lock), (usec), (flags))
-#else
-#define _condvar_wait_timeout_spinlock(cv, lock, usec, flags) \
-        _condvar_wait_timeout_spinlock_impl((cv), NULL, (usec), (flags))
-#endif
-
 extern void condvar_initialize(condvar_t *cv);
 extern void condvar_signal(condvar_t *cv);
 extern void condvar_broadcast(condvar_t *cv);
 
-extern errno_t condvar_wait(condvar_t *cv, mutex_t *mtx);
-extern errno_t condvar_wait_timeout(condvar_t *cv, mutex_t *mtx, uint32_t usec);
+extern errno_t __condvar_wait_mutex(condvar_t *cv, mutex_t *mtx);
+extern errno_t __condvar_wait_spinlock(condvar_t *cv, spinlock_t *mtx);
+extern errno_t __condvar_wait_irq_spinlock(condvar_t *cv, irq_spinlock_t *mtx);
+extern errno_t __condvar_wait_timeout_mutex(condvar_t *cv, mutex_t *mtx, uint32_t usec);
+extern errno_t __condvar_wait_timeout_spinlock(condvar_t *cv, spinlock_t *mtx, uint32_t usec);
+extern errno_t __condvar_wait_timeout_irq_spinlock(condvar_t *cv, irq_spinlock_t *mtx, uint32_t usec);
 
-extern errno_t _condvar_wait_timeout_spinlock_impl(condvar_t *cv, spinlock_t *lock,
-    uint32_t usec, int flags);
-extern errno_t _condvar_wait_timeout_irq_spinlock(condvar_t *cv,
-    irq_spinlock_t *irq_lock, uint32_t usec, int flags);
+#define condvar_wait(cv, mtx) (_Generic((mtx), \
+        mutex_t *: __condvar_wait_mutex, \
+        spinlock_t *: __condvar_wait_spinlock, \
+        irq_spinlock_t *: __condvar_wait_irq_spinlock \
+)(cv, mtx))
+
+#define condvar_wait_timeout(cv, mtx, usec) (_Generic((mtx), \
+        mutex_t *: __condvar_wait_timeout_mutex, \
+        spinlock_t *: __condvar_wait_timeout_spinlock, \
+        irq_spinlock_t *: __condvar_wait_timeout_irq_spinlock \
+)(cv, mtx))
 
 #endif