Changeset 166a1f57 in mainline for uspace/srv/ns/task.c

Timestamp:

2013-04-12T15:13:36Z (12 years ago)

Author:

Martin Sucha <sucha14@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ed267bc

Parents:

bc4bf97

Message:

Fix use-after-free in ns

File:

• uspace/srv/ns/task.c (modified) (3 diffs)

uspace/srv/ns/task.c

@@ -208 +208 @@
         sysarg_t retval;
         task_exit_t texit;
+        bool remove = false;
         
         ht_link_t *link = hash_table_find(&task_hash_table, &id);
@@ -235 +236 @@
         }
         
-        hash_table_remove_item(&task_hash_table, link);
+        remove = true;
         retval = EOK;
         
@@ -243 +244 @@
                 ipc_answer_2(callid, retval, texit, ht->retval);
         }
+        if (remove)
+                hash_table_remove_item(&task_hash_table, link);
 }