Changeset 1a3b953 in mainline for uspace/lib/bithenge/blob.c

Timestamp:

2012-08-20T00:22:19Z (13 years ago)

Author:

Sean Bartell <wingedtachikoma@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0784869

Parents:

5e514c0

Message:

Bithenge: better error injection

File:

• uspace/lib/bithenge/blob.c (modified) (5 diffs)

uspace/lib/bithenge/blob.c

@@ -58 +58 @@
         assert(ops->size);
 
+        if (bithenge_should_fail())
+                return ENOMEM;
+
         blob->base.type = BITHENGE_NODE_BLOB;
         blob->base.refs = 1;
@@ -195 +198 @@
 {
         memory_blob_t *blob = blob_as_memory(base);
+        if (bithenge_should_fail())
+                return EIO;
         *size = blob->size;
         return EOK;
@@ -223 +228 @@
         .destroy = memory_destroy,
 };
-
-/** Create a blob node from data. Unlike with @a
- * bithenge_blob_t::bithenge_new_blob_from_buffer, the data is copied into a
- * new buffer and the original data can be changed after this call. The blob
- * must be freed with @a bithenge_node_t::bithenge_node_destroy after it is
- * used.
- * @memberof bithenge_blob_t
- * @param[out] out Stores the created blob node.
- * @param[in] data The data.
- * @param len The length of the data.
- * @return EOK on success or an error code from errno.h. */
-int bithenge_new_blob_from_data(bithenge_node_t **out, const void *data,
-    size_t len)
-{
-        int rc;
-        assert(data || !len);
-
-        memory_blob_t *blob = malloc(sizeof(*blob));
-        if (!blob)
-                return ENOMEM;
-        rc = bithenge_init_random_access_blob(memory_as_blob(blob),
-            &memory_ops);
-        if (rc != EOK) {
-                free(blob);
-                return rc;
-        }
-        char *buffer = malloc(len);
-        if (!buffer) {
-                free(blob);
-                return rc;
-        }
-        memcpy(buffer, data, len);
-        blob->buffer = buffer;
-        blob->size = len;
-        blob->needs_free = true;
-        *out = bithenge_blob_as_node(memory_as_blob(blob));
-        return EOK;
-}
 
 /** Create a blob node from a buffer. The buffer must exist as long as the blob
@@ -280 +247 @@
 
         memory_blob_t *blob = malloc(sizeof(*blob));
-        if (!blob)
-                return ENOMEM;
+        if (!blob) {
+                rc = ENOMEM;
+                goto error;
+        }
         rc = bithenge_init_random_access_blob(memory_as_blob(blob),
             &memory_ops);
-        if (rc != EOK) {
-                free(blob);
-                return rc;
-        }
+        if (rc != EOK)
+                goto error;
         blob->buffer = buffer;
         blob->size = len;
@@ -293 +260 @@
         *out = bithenge_blob_as_node(memory_as_blob(blob));
         return EOK;
-}
+        
+error:
+        if (needs_free)
+                free((void *)buffer);
+        free(blob);
+        return rc;
+}
+
+/** Create a blob node from data. Unlike with @a
+ * bithenge_blob_t::bithenge_new_blob_from_buffer, the data is copied into a
+ * new buffer and the original data can be changed after this call. The blob
+ * must be freed with @a bithenge_node_t::bithenge_node_destroy after it is
+ * used.
+ * @memberof bithenge_blob_t
+ * @param[out] out Stores the created blob node.
+ * @param[in] data The data.
+ * @param len The length of the data.
+ * @return EOK on success or an error code from errno.h. */
+int bithenge_new_blob_from_data(bithenge_node_t **out, const void *data,
+    size_t len)
+{
+        char *buffer = malloc(len);
+        if (!buffer)
+                return ENOMEM;
+        memcpy(buffer, data, len);
+
+        return bithenge_new_blob_from_buffer(out, buffer, len, true);
+}
+
+
 
 typedef struct {