Changeset 33b8d024 in mainline for uspace/srv/audio/hound/audio_data.c

Timestamp:

2018-01-16T20:38:46Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2467b41

Parents:

d39c46e0

Message:

Remove const qualifier from the argument of free() and realloc(),
as well as in numerous other variables that hold ownership of memory.

By convention, a pointer that holds ownership is _never_ qualified by const.
This is reflected in the standard type signature of free() and realloc().
Allowing const pointers to hold ownership may seem superficially convenient,
but is actually quite confusing to experienced C programmers.

File:

• uspace/srv/audio/hound/audio_data.c (modified) (4 diffs)

uspace/srv/audio/hound/audio_data.c

@@ -36 +36 @@
 #include <macros.h>
 #include <stdlib.h>
+#include <str.h>
 
 #include "audio_data.h"
@@ -50 +51 @@
     pcm_format_t format)
 {
-        audio_data_t *adata = malloc(sizeof(audio_data_t));
+        audio_data_t *adata = malloc(sizeof(audio_data_t) + size);
         if (adata) {
                 unsigned overflow = size % pcm_format_frame_size(&format);
@@ -56 +57 @@
                         log_warning("Data not a multiple of frame size, "
                             "clipping.");
-
-                adata->data = data;
+                uint8_t *d = ((uint8_t *)adata) + offsetof(audio_data_t, data);
+                memcpy(d, data, size);
                 adata->size = size - overflow;
                 adata->format = format;
@@ -86 +87 @@
         atomic_count_t refc = atomic_predec(&adata->refcount);
         if (refc == 0) {
-                free(adata->data);
                 free(adata);
         }