Changeset 33b8d024 in mainline for uspace/srv/audio/hound/audio_source.h

Timestamp:

2018-01-16T20:38:46Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2467b41

Parents:

d39c46e0

Message:

Remove const qualifier from the argument of free() and realloc(),
as well as in numerous other variables that hold ownership of memory.

By convention, a pointer that holds ownership is _never_ qualified by const.
This is reflected in the standard type signature of free() and realloc().
Allowing const pointers to hold ownership may seem superficially convenient,
but is actually quite confusing to experienced C programmers.

File:

• uspace/srv/audio/hound/audio_source.h (modified) (2 diffs)

uspace/srv/audio/hound/audio_source.h

@@ -49 +49 @@
         list_t connections;
         /** String identifier */
-        const char *name;
+        char *name;
         /** audio data format */
         pcm_format_t format;
@@ -75 +75 @@
     const pcm_format_t *f);
 void audio_source_fini(audio_source_t *source);
-errno_t audio_source_push_data(audio_source_t *source, const void *data,
+errno_t audio_source_push_data(audio_source_t *source, void *data,
     size_t size);
 static inline const pcm_format_t *audio_source_format(const audio_source_t *s)